godotengine/godot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
b04b546092
godot/editor/property_selector.cpp

576 lines
18 KiB
C++
Raw Normal View History

One Copyright Update to rule them all As many open source projects have started doing it, we're removing the current year from the copyright notice, so that we don't need to bump it every year. It seems like only the first year of publication is technically relevant for copyright notices, and even that seems to be something that many companies stopped listing altogether (in a version controlled codebase, the commits are a much better source of date of publication than a hardcoded copyright statement). We also now list Godot Engine contributors first as we're collectively the current maintainers of the project, and we clarify that the "exclusive" copyright of the co-founders covers the timespan before opensourcing (their further contributions are included as part of Godot Engine contributors). Also fixed "cf." Frenchism - it's meant as "refer to / see".
2023-01-05 12:25:55 +00:00
/**************************************************************************/
/* property_selector.cpp */
/**************************************************************************/
/* This file is part of: */
/* GODOT ENGINE */
/* https://godotengine.org */
/**************************************************************************/
/* Copyright (c) 2014-present Godot Engine contributors (see AUTHORS.md). */
/* Copyright (c) 2007-2014 Juan Linietsky, Ariel Manzur. */
/* */
/* Permission is hereby granted, free of charge, to any person obtaining */
/* a copy of this software and associated documentation files (the */
/* "Software"), to deal in the Software without restriction, including */
/* without limitation the rights to use, copy, modify, merge, publish, */
/* distribute, sublicense, and/or sell copies of the Software, and to */
/* permit persons to whom the Software is furnished to do so, subject to */
/* the following conditions: */
/* */
/* The above copyright notice and this permission notice shall be */
/* included in all copies or substantial portions of the Software. */
/* */
/* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, */
/* EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF */
/* MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. */
/* IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY */
/* CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, */
/* TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE */
/* SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE. */
/**************************************************************************/
Add missing copyright headers and fix formatting Using `misc/scripts/fix_headers.py` on all Godot files. Some missing header guards were added, and the header inclusion order was fixed in the Bullet module.
2018-01-04 23:50:27 +00:00
Proper function/property selection in visual script editing for property. This one has an ordered list, built-in description, search, etc.
2016-08-23 22:29:07 +00:00
#include "property_selector.h"
Make core/ includes absolute, remove subfolders from include path This allows more consistency in the manner we include core headers, where previously there would be a mix of absolute, relative and include path-dependent includes.
2018-09-11 16:13:45 +00:00
#include "core/os/keyboard.h"
Refactor DocData into core and editor (DocTools) parts
2020-11-29 03:42:06 +00:00
#include "editor/doc_tools.h"
Remove excessive `editor/property_editor.h` includes
2022-08-01 14:04:35 +00:00
#include "editor/editor_help.h"
Refactor editor icon retrieval
2018-09-02 21:40:51 +00:00
#include "editor/editor_node.h"
Improve compilation speed (forward declarations/includes cleanup)
2022-02-12 01:46:22 +00:00
#include "editor/editor_scale.h"
Remove excessive `editor/property_editor.h` includes
2022-08-01 14:04:35 +00:00
#include "scene/gui/line_edit.h"
#include "scene/gui/rich_text_label.h"
#include "scene/gui/tree.h"
Proper function/property selection in visual script editing for property. This one has an ordered list, built-in description, search, etc.
2016-08-23 22:29:07 +00:00
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
void PropertySelector::_text_changed(const String &p_newtext) {
Proper function/property selection in visual script editing for property. This one has an ordered list, built-in description, search, etc.
2016-08-23 22:29:07 +00:00
_update_search();
}
Removal of InputEvent as built-in Variant type.. this might cause bugs I haven't found yet..
2017-05-20 15:38:03 +00:00
void PropertySelector::_sbox_input(const Ref<InputEvent> &p_ie) {
Ref<InputEventKey> k = p_ie;
Proper function/property selection in visual script editing for property. This one has an ordered list, built-in description, search, etc.
2016-08-23 22:29:07 +00:00
Removal of InputEvent as built-in Variant type.. this might cause bugs I haven't found yet..
2017-05-20 15:38:03 +00:00
if (k.is_valid()) {
Rename `scancode` to `keycode`. Add `physical_keycode` (keyboard layout independent keycodes) to InputEventKey and InputMap. Fix non-latin keyboard layout keycodes on Linux/X11 (fallback to physical keycodes).
2018-04-05 17:59:35 +00:00
switch (k->get_keycode()) {
Use "enum class" for input enums
2021-08-13 21:31:57 +00:00
case Key::UP:
case Key::DOWN:
case Key::PAGEUP:
case Key::PAGEDOWN: {
Entirely removes BIND_VMETHOD in favor of GDVIRTUAL * `_gui_input`, `_input`, `_unhandled_input` and `_unhandled_key_input` are now regular C++ virutal functions. * Everything else converted to GDVIRTUAL * BIND_VMETHOD is gone, always use the new syntax from now on. Creating `_gui_input` method and using the binder to register events will no longer work, simply override the virtual function now.
2021-08-22 15:37:22 +00:00
search_options->gui_input(k);
Proper function/property selection in visual script editing for property. This one has an ordered list, built-in description, search, etc.
2016-08-23 22:29:07 +00:00
search_box->accept_event();
TreeItem *root = search_options->get_root();
Improve TreeItem API and allow to move nodes
2021-03-07 20:07:30 +00:00
if (!root->get_first_child()) {
Proper function/property selection in visual script editing for property. This one has an ordered list, built-in description, search, etc.
2016-08-23 22:29:07 +00:00
break;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
}
Proper function/property selection in visual script editing for property. This one has an ordered list, built-in description, search, etc.
2016-08-23 22:29:07 +00:00
TreeItem *current = search_options->get_selected();
TreeItem *item = search_options->get_next_selected(root);
while (item) {
item->deselect(0);
item = search_options->get_next_selected(item);
}
current->select(0);
} break;
Use Key enum instead of plain integers
2021-06-20 17:12:33 +00:00
default:
break;
Proper function/property selection in visual script editing for property. This one has an ordered list, built-in description, search, etc.
2016-08-23 22:29:07 +00:00
}
}
}
void PropertySelector::_update_search() {
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
if (properties) {
Proper function/property selection in visual script editing for property. This one has an ordered list, built-in description, search, etc.
2016-08-23 22:29:07 +00:00
set_title(TTR("Select Property"));
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
} else if (virtuals_only) {
Many fixes to visual script, changed virtuals override for a proper selector.
2017-09-12 10:58:18 +00:00
set_title(TTR("Select Virtual Method"));
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
} else {
Proper function/property selection in visual script editing for property. This one has an ordered list, built-in description, search, etc.
2016-08-23 22:29:07 +00:00
set_title(TTR("Select Method"));
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
}
Proper function/property selection in visual script editing for property. This one has an ordered list, built-in description, search, etc.
2016-08-23 22:29:07 +00:00
search_options->clear();
Making bits of docs appear in different dialogues is made easier with EditorHelpBit
2016-08-24 02:15:16 +00:00
help_bit->set_text("");
Proper function/property selection in visual script editing for property. This one has an ordered list, built-in description, search, etc.
2016-08-23 22:29:07 +00:00
TreeItem *root = search_options->create_item();
Improve search and display in the editor property/method selector - Use postfix notation for types in the method selector (for consistency with the editor help). - Perform a case-insensitive match and replace spaces with underscores in the search string. - Fix extraneous space after the `void` return type.
2020-08-19 16:28:05 +00:00
// Allow using spaces in place of underscores in the search string (makes the search more fault-tolerant).
const String search_text = search_box->get_text().replace(" ", "_");
Proper function/property selection in visual script editing for property. This one has an ordered list, built-in description, search, etc.
2016-08-23 22:29:07 +00:00
if (properties) {
List<PropertyInfo> props;
if (instance) {
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
instance->get_property_list(&props, true);
} else if (type != Variant::NIL) {
Proper function/property selection in visual script editing for property. This one has an ordered list, built-in description, search, etc.
2016-08-23 22:29:07 +00:00
Variant v;
Reworked signal connection system, added support for Callable and Signal objects and made them default.
2020-02-19 19:27:19 +00:00
Callable::CallError ce;
Refactored variant constructor logic
2020-11-09 03:19:09 +00:00
Variant::construct(type, v, nullptr, 0, ce);
Proper function/property selection in visual script editing for property. This one has an ordered list, built-in description, search, etc.
2016-08-23 22:29:07 +00:00
v.get_property_list(&props);
} else {
Object *obj = ObjectDB::get_instance(script);
Convert Object::cast_to() to the static version Currently we rely on some undefined behavior when Object->cast_to() gets called with a Null pointer. This used to work fine with GCC < 6 but newer versions of GCC remove all codepaths in which the this pointer is Null. However, the non-static cast_to() was supposed to be null safe. This patch makes cast_to() Null safe and removes the now redundant Null checks where they existed. It is explained in this article: https://www.viva64.com/en/b/0226/
2017-08-24 20:58:51 +00:00
if (Object::cast_to<Script>(obj)) {
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
props.push_back(PropertyInfo(Variant::NIL, "Script Variables", PROPERTY_HINT_NONE, "", PROPERTY_USAGE_CATEGORY));
Convert Object::cast_to() to the static version Currently we rely on some undefined behavior when Object->cast_to() gets called with a Null pointer. This used to work fine with GCC < 6 but newer versions of GCC remove all codepaths in which the this pointer is Null. However, the non-static cast_to() was supposed to be null safe. This patch makes cast_to() Null safe and removes the now redundant Null checks where they existed. It is explained in this article: https://www.viva64.com/en/b/0226/
2017-08-24 20:58:51 +00:00
Object::cast_to<Script>(obj)->get_script_property_list(&props);
Proper function/property selection in visual script editing for property. This one has an ordered list, built-in description, search, etc.
2016-08-23 22:29:07 +00:00
}
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
StringName base = base_type;
while (base) {
props.push_back(PropertyInfo(Variant::NIL, base, PROPERTY_HINT_NONE, "", PROPERTY_USAGE_CATEGORY));
ClassDB::get_property_list(base, &props, true);
base = ClassDB::get_parent_class(base);
Proper function/property selection in visual script editing for property. This one has an ordered list, built-in description, search, etc.
2016-08-23 22:29:07 +00:00
}
}
Replace NULL with nullptr
2020-04-01 23:20:12 +00:00
TreeItem *category = nullptr;
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
bool found = false;
Fix type icons in `PropertySelector` And adding a check to prevent future issues.
2023-03-06 11:29:46 +00:00
Ref<Texture2D> type_icons[] = {
Add EditorStringNames singleton
2023-08-13 00:33:39 +00:00
search_options->get_editor_theme_icon(SNAME("Variant")),
search_options->get_editor_theme_icon(SNAME("bool")),
search_options->get_editor_theme_icon(SNAME("int")),
search_options->get_editor_theme_icon(SNAME("float")),
search_options->get_editor_theme_icon(SNAME("String")),
search_options->get_editor_theme_icon(SNAME("Vector2")),
search_options->get_editor_theme_icon(SNAME("Vector2i")),
search_options->get_editor_theme_icon(SNAME("Rect2")),
search_options->get_editor_theme_icon(SNAME("Rect2i")),
search_options->get_editor_theme_icon(SNAME("Vector3")),
search_options->get_editor_theme_icon(SNAME("Vector3i")),
search_options->get_editor_theme_icon(SNAME("Transform2D")),
search_options->get_editor_theme_icon(SNAME("Vector4")),
search_options->get_editor_theme_icon(SNAME("Vector4i")),
search_options->get_editor_theme_icon(SNAME("Plane")),
search_options->get_editor_theme_icon(SNAME("Quaternion")),
search_options->get_editor_theme_icon(SNAME("AABB")),
search_options->get_editor_theme_icon(SNAME("Basis")),
search_options->get_editor_theme_icon(SNAME("Transform3D")),
search_options->get_editor_theme_icon(SNAME("Projection")),
search_options->get_editor_theme_icon(SNAME("Color")),
search_options->get_editor_theme_icon(SNAME("StringName")),
search_options->get_editor_theme_icon(SNAME("NodePath")),
search_options->get_editor_theme_icon(SNAME("RID")),
search_options->get_editor_theme_icon(SNAME("MiniObject")),
search_options->get_editor_theme_icon(SNAME("Callable")),
search_options->get_editor_theme_icon(SNAME("Signal")),
search_options->get_editor_theme_icon(SNAME("Dictionary")),
search_options->get_editor_theme_icon(SNAME("Array")),
search_options->get_editor_theme_icon(SNAME("PackedByteArray")),
search_options->get_editor_theme_icon(SNAME("PackedInt32Array")),
search_options->get_editor_theme_icon(SNAME("PackedInt64Array")),
search_options->get_editor_theme_icon(SNAME("PackedFloat32Array")),
search_options->get_editor_theme_icon(SNAME("PackedFloat64Array")),
search_options->get_editor_theme_icon(SNAME("PackedStringArray")),
search_options->get_editor_theme_icon(SNAME("PackedVector2Array")),
search_options->get_editor_theme_icon(SNAME("PackedVector3Array")),
search_options->get_editor_theme_icon(SNAME("PackedColorArray"))
Proper function/property selection in visual script editing for property. This one has an ordered list, built-in description, search, etc.
2016-08-23 22:29:07 +00:00
};
Fix type icons in `PropertySelector` And adding a check to prevent future issues.
2023-03-06 11:29:46 +00:00
static_assert((sizeof(type_icons) / sizeof(type_icons[0])) == Variant::VARIANT_MAX, "Number of type icons doesn't match the number of Variant types.");
Proper function/property selection in visual script editing for property. This one has an ordered list, built-in description, search, etc.
2016-08-23 22:29:07 +00:00
Use const references where possible for List range iterators
2021-07-24 13:46:25 +00:00
for (const PropertyInfo &E : props) {
Use C++ iterators for Lists in many situations
2021-07-16 03:45:57 +00:00
if (E.usage == PROPERTY_USAGE_CATEGORY) {
Improve TreeItem API and allow to move nodes
2021-03-07 20:07:30 +00:00
if (category && category->get_first_child() == nullptr) {
Proper function/property selection in visual script editing for property. This one has an ordered list, built-in description, search, etc.
2016-08-23 22:29:07 +00:00
memdelete(category); //old category was unused
}
category = search_options->create_item(root);
Use C++ iterators for Lists in many situations
2021-07-16 03:45:57 +00:00
category->set_text(0, E.name);
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
category->set_selectable(0, false);
Proper function/property selection in visual script editing for property. This one has an ordered list, built-in description, search, etc.
2016-08-23 22:29:07 +00:00
Texture refactor -Texture renamed to Texture2D -TextureLayered as base now inherits 2Darray, cubemap and cubemap array -Removed all references to flags in textures (they will go in the shader) -Texture3D gone for now (will come back later done properly) -Create base rasterizer for RenderDevice, RasterizerRD
2019-06-11 18:43:37 +00:00
Ref<Texture2D> icon;
Use C++ iterators for Lists in many situations
2021-07-16 03:45:57 +00:00
if (E.name == "Script Variables") {
Add EditorStringNames singleton
2023-08-13 00:33:39 +00:00
icon = search_options->get_editor_theme_icon(SNAME("Script"));
Proper function/property selection in visual script editing for property. This one has an ordered list, built-in description, search, etc.
2016-08-23 22:29:07 +00:00
} else {
Use C++ iterators for Lists in many situations
2021-07-16 03:45:57 +00:00
icon = EditorNode::get_singleton()->get_class_icon(E.name);
Proper function/property selection in visual script editing for property. This one has an ordered list, built-in description, search, etc.
2016-08-23 22:29:07 +00:00
}
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
category->set_icon(0, icon);
Proper function/property selection in visual script editing for property. This one has an ordered list, built-in description, search, etc.
2016-08-23 22:29:07 +00:00
continue;
}
Use C++ iterators for Lists in many situations
2021-07-16 03:45:57 +00:00
if (!(E.usage & PROPERTY_USAGE_EDITOR) && !(E.usage & PROPERTY_USAGE_SCRIPT_VARIABLE)) {
Proper function/property selection in visual script editing for property. This one has an ordered list, built-in description, search, etc.
2016-08-23 22:29:07 +00:00
continue;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
}
Proper function/property selection in visual script editing for property. This one has an ordered list, built-in description, search, etc.
2016-08-23 22:29:07 +00:00
Replace String comparisons with "", String() to is_empty() Also: - Adds two stress tests to test_string.h - Changes to .empty() on std::strings
2021-12-09 09:42:46 +00:00
if (!search_box->get_text().is_empty() && E.name.findn(search_text) == -1) {
Proper function/property selection in visual script editing for property. This one has an ordered list, built-in description, search, etc.
2016-08-23 22:29:07 +00:00
continue;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
}
Entirely new (and much improved) animation editor.
2018-06-07 15:46:14 +00:00
Vectors: Use clear() and has(). Use clear() instead of resize(0). Use has() instead of "find(p_val) != -1".
2022-02-01 18:19:13 +00:00
if (type_filter.size() && !type_filter.has(E.type)) {
Entirely new (and much improved) animation editor.
2018-06-07 15:46:14 +00:00
continue;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
}
Entirely new (and much improved) animation editor.
2018-06-07 15:46:14 +00:00
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
TreeItem *item = search_options->create_item(category ? category : root);
Use C++ iterators for Lists in many situations
2021-07-16 03:45:57 +00:00
item->set_text(0, E.name);
item->set_metadata(0, E.name);
item->set_icon(0, type_icons[E.type]);
Proper function/property selection in visual script editing for property. This one has an ordered list, built-in description, search, etc.
2016-08-23 22:29:07 +00:00
Replace String comparisons with "", String() to is_empty() Also: - Adds two stress tests to test_string.h - Changes to .empty() on std::strings
2021-12-09 09:42:46 +00:00
if (!found && !search_box->get_text().is_empty() && E.name.findn(search_text) != -1) {
Proper function/property selection in visual script editing for property. This one has an ordered list, built-in description, search, etc.
2016-08-23 22:29:07 +00:00
item->select(0);
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
found = true;
Proper function/property selection in visual script editing for property. This one has an ordered list, built-in description, search, etc.
2016-08-23 22:29:07 +00:00
}
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
item->set_selectable(0, true);
Proper function/property selection in visual script editing for property. This one has an ordered list, built-in description, search, etc.
2016-08-23 22:29:07 +00:00
}
Improve TreeItem API and allow to move nodes
2021-03-07 20:07:30 +00:00
if (category && category->get_first_child() == nullptr) {
Proper function/property selection in visual script editing for property. This one has an ordered list, built-in description, search, etc.
2016-08-23 22:29:07 +00:00
memdelete(category); //old category was unused
}
} else {
List<MethodInfo> methods;
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
if (type != Variant::NIL) {
Proper function/property selection in visual script editing for property. This one has an ordered list, built-in description, search, etc.
2016-08-23 22:29:07 +00:00
Variant v;
Reworked signal connection system, added support for Callable and Signal objects and made them default.
2020-02-19 19:27:19 +00:00
Callable::CallError ce;
Refactored variant constructor logic
2020-11-09 03:19:09 +00:00
Variant::construct(type, v, nullptr, 0, ce);
Proper function/property selection in visual script editing for property. This one has an ordered list, built-in description, search, etc.
2016-08-23 22:29:07 +00:00
v.get_method_list(&methods);
} else {
Reload built-in scripts when picking methods
2022-02-08 15:06:57 +00:00
Ref<Script> script_ref = Object::cast_to<Script>(ObjectDB::get_instance(script));
if (script_ref.is_valid()) {
Proper function/property selection in visual script editing for property. This one has an ordered list, built-in description, search, etc.
2016-08-23 22:29:07 +00:00
methods.push_back(MethodInfo("*Script Methods"));
Reload built-in scripts when picking methods
2022-02-08 15:06:57 +00:00
if (script_ref->is_built_in()) {
script_ref->reload(true);
}
script_ref->get_script_method_list(&methods);
Proper function/property selection in visual script editing for property. This one has an ordered list, built-in description, search, etc.
2016-08-23 22:29:07 +00:00
}
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
StringName base = base_type;
while (base) {
methods.push_back(MethodInfo("*" + String(base)));
Many fixes to visual script, changed virtuals override for a proper selector.
2017-09-12 10:58:18 +00:00
ClassDB::get_method_list(base, &methods, true, true);
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
base = ClassDB::get_parent_class(base);
Proper function/property selection in visual script editing for property. This one has an ordered list, built-in description, search, etc.
2016-08-23 22:29:07 +00:00
}
}
Replace NULL with nullptr
2020-04-01 23:20:12 +00:00
TreeItem *category = nullptr;
Proper function/property selection in visual script editing for property. This one has an ordered list, built-in description, search, etc.
2016-08-23 22:29:07 +00:00
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
bool found = false;
bool script_methods = false;
Proper function/property selection in visual script editing for property. This one has an ordered list, built-in description, search, etc.
2016-08-23 22:29:07 +00:00
Use C++ iterators for Lists in many situations
2021-07-16 03:45:57 +00:00
for (MethodInfo &mi : methods) {
if (mi.name.begins_with("*")) {
Improve TreeItem API and allow to move nodes
2021-03-07 20:07:30 +00:00
if (category && category->get_first_child() == nullptr) {
Proper function/property selection in visual script editing for property. This one has an ordered list, built-in description, search, etc.
2016-08-23 22:29:07 +00:00
memdelete(category); //old category was unused
}
category = search_options->create_item(root);
Use C++ iterators for Lists in many situations
2021-07-16 03:45:57 +00:00
category->set_text(0, mi.name.replace_first("*", ""));
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
category->set_selectable(0, false);
Proper function/property selection in visual script editing for property. This one has an ordered list, built-in description, search, etc.
2016-08-23 22:29:07 +00:00
Texture refactor -Texture renamed to Texture2D -TextureLayered as base now inherits 2Darray, cubemap and cubemap array -Removed all references to flags in textures (they will go in the shader) -Texture3D gone for now (will come back later done properly) -Create base rasterizer for RenderDevice, RasterizerRD
2019-06-11 18:43:37 +00:00
Ref<Texture2D> icon;
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
script_methods = false;
Use C++ iterators for Lists in many situations
2021-07-16 03:45:57 +00:00
String rep = mi.name.replace("*", "");
if (mi.name == "*Script Methods") {
Add EditorStringNames singleton
2023-08-13 00:33:39 +00:00
icon = search_options->get_editor_theme_icon(SNAME("Script"));
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
script_methods = true;
Proper function/property selection in visual script editing for property. This one has an ordered list, built-in description, search, etc.
2016-08-23 22:29:07 +00:00
} else {
Refactor editor icon retrieval
2018-09-02 21:40:51 +00:00
icon = EditorNode::get_singleton()->get_class_icon(rep);
Proper function/property selection in visual script editing for property. This one has an ordered list, built-in description, search, etc.
2016-08-23 22:29:07 +00:00
}
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
category->set_icon(0, icon);
Proper function/property selection in visual script editing for property. This one has an ordered list, built-in description, search, etc.
2016-08-23 22:29:07 +00:00
continue;
}
Use C++ iterators for Lists in many situations
2021-07-16 03:45:57 +00:00
String name = mi.name.get_slice(":", 0);
if (!script_methods && name.begins_with("_") && !(mi.flags & METHOD_FLAG_VIRTUAL)) {
Proper function/property selection in visual script editing for property. This one has an ordered list, built-in description, search, etc.
2016-08-23 22:29:07 +00:00
continue;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
}
Proper function/property selection in visual script editing for property. This one has an ordered list, built-in description, search, etc.
2016-08-23 22:29:07 +00:00
Use C++ iterators for Lists in many situations
2021-07-16 03:45:57 +00:00
if (virtuals_only && !(mi.flags & METHOD_FLAG_VIRTUAL)) {
Many fixes to visual script, changed virtuals override for a proper selector.
2017-09-12 10:58:18 +00:00
continue;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
}
Many fixes to visual script, changed virtuals override for a proper selector.
2017-09-12 10:58:18 +00:00
Use C++ iterators for Lists in many situations
2021-07-16 03:45:57 +00:00
if (!virtuals_only && (mi.flags & METHOD_FLAG_VIRTUAL)) {
Many fixes to visual script, changed virtuals override for a proper selector.
2017-09-12 10:58:18 +00:00
continue;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
}
Many fixes to visual script, changed virtuals override for a proper selector.
2017-09-12 10:58:18 +00:00
Replace String comparisons with "", String() to is_empty() Also: - Adds two stress tests to test_string.h - Changes to .empty() on std::strings
2021-12-09 09:42:46 +00:00
if (!search_box->get_text().is_empty() && name.findn(search_text) == -1) {
Proper function/property selection in visual script editing for property. This one has an ordered list, built-in description, search, etc.
2016-08-23 22:29:07 +00:00
continue;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
}
Proper function/property selection in visual script editing for property. This one has an ordered list, built-in description, search, etc.
2016-08-23 22:29:07 +00:00
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
TreeItem *item = search_options->create_item(category ? category : root);
Proper function/property selection in visual script editing for property. This one has an ordered list, built-in description, search, etc.
2016-08-23 22:29:07 +00:00
String desc;
String: Add contains().
2022-02-03 16:03:38 +00:00
if (mi.name.contains(":")) {
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
desc = mi.name.get_slice(":", 1) + " ";
mi.name = mi.name.get_slice(":", 0);
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
} else if (mi.return_val.type != Variant::NIL) {
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
desc = Variant::get_type_name(mi.return_val.type);
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
} else {
Improve search and display in the editor property/method selector - Use postfix notation for types in the method selector (for consistency with the editor help). - Perform a case-insensitive match and replace spaces with underscores in the search string. - Fix extraneous space after the `void` return type.
2020-08-19 16:28:05 +00:00
desc = "void";
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
}
Proper function/property selection in visual script editing for property. This one has an ordered list, built-in description, search, etc.
2016-08-23 22:29:07 +00:00
Improve search and display in the editor property/method selector - Use postfix notation for types in the method selector (for consistency with the editor help). - Perform a case-insensitive match and replace spaces with underscores in the search string. - Fix extraneous space after the `void` return type.
2020-08-19 16:28:05 +00:00
desc += vformat(" %s(", mi.name);
Proper function/property selection in visual script editing for property. This one has an ordered list, built-in description, search, etc.
2016-08-23 22:29:07 +00:00
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
for (int i = 0; i < mi.arguments.size(); i++) {
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
if (i > 0) {
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
desc += ", ";
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
}
Proper function/property selection in visual script editing for property. This one has an ordered list, built-in description, search, etc.
2016-08-23 22:29:07 +00:00
Improve search and display in the editor property/method selector - Use postfix notation for types in the method selector (for consistency with the editor help). - Perform a case-insensitive match and replace spaces with underscores in the search string. - Fix extraneous space after the `void` return type.
2020-08-19 16:28:05 +00:00
desc += mi.arguments[i].name;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
if (mi.arguments[i].type == Variant::NIL) {
Improve search and display in the editor property/method selector - Use postfix notation for types in the method selector (for consistency with the editor help). - Perform a case-insensitive match and replace spaces with underscores in the search string. - Fix extraneous space after the `void` return type.
2020-08-19 16:28:05 +00:00
desc += ": Variant";
String: Add contains().
2022-02-03 16:03:38 +00:00
} else if (mi.arguments[i].name.contains(":")) {
Improve search and display in the editor property/method selector - Use postfix notation for types in the method selector (for consistency with the editor help). - Perform a case-insensitive match and replace spaces with underscores in the search string. - Fix extraneous space after the `void` return type.
2020-08-19 16:28:05 +00:00
desc += vformat(": %s", mi.arguments[i].name.get_slice(":", 1));
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
mi.arguments[i].name = mi.arguments[i].name.get_slice(":", 0);
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
} else {
Improve search and display in the editor property/method selector - Use postfix notation for types in the method selector (for consistency with the editor help). - Perform a case-insensitive match and replace spaces with underscores in the search string. - Fix extraneous space after the `void` return type.
2020-08-19 16:28:05 +00:00
desc += vformat(": %s", Variant::get_type_name(mi.arguments[i].type));
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
}
Proper function/property selection in visual script editing for property. This one has an ordered list, built-in description, search, etc.
2016-08-23 22:29:07 +00:00
}
Improve search and display in the editor property/method selector - Use postfix notation for types in the method selector (for consistency with the editor help). - Perform a case-insensitive match and replace spaces with underscores in the search string. - Fix extraneous space after the `void` return type.
2020-08-19 16:28:05 +00:00
desc += ")";
Proper function/property selection in visual script editing for property. This one has an ordered list, built-in description, search, etc.
2016-08-23 22:29:07 +00:00
Use C++ iterators for Lists in many situations
2021-07-16 03:45:57 +00:00
if (mi.flags & METHOD_FLAG_CONST) {
Many fixes to visual script, changed virtuals override for a proper selector.
2017-09-12 10:58:18 +00:00
desc += " const";
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
}
Many fixes to visual script, changed virtuals override for a proper selector.
2017-09-12 10:58:18 +00:00
Use C++ iterators for Lists in many situations
2021-07-16 03:45:57 +00:00
if (mi.flags & METHOD_FLAG_VIRTUAL) {
Many fixes to visual script, changed virtuals override for a proper selector.
2017-09-12 10:58:18 +00:00
desc += " virtual";
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
}
Many fixes to visual script, changed virtuals override for a proper selector.
2017-09-12 10:58:18 +00:00
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
item->set_text(0, desc);
item->set_metadata(0, name);
item->set_selectable(0, true);
Proper function/property selection in visual script editing for property. This one has an ordered list, built-in description, search, etc.
2016-08-23 22:29:07 +00:00
Replace String comparisons with "", String() to is_empty() Also: - Adds two stress tests to test_string.h - Changes to .empty() on std::strings
2021-12-09 09:42:46 +00:00
if (!found && !search_box->get_text().is_empty() && name.findn(search_text) != -1) {
Proper function/property selection in visual script editing for property. This one has an ordered list, built-in description, search, etc.
2016-08-23 22:29:07 +00:00
item->select(0);
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
found = true;
Proper function/property selection in visual script editing for property. This one has an ordered list, built-in description, search, etc.
2016-08-23 22:29:07 +00:00
}
}
Improve TreeItem API and allow to move nodes
2021-03-07 20:07:30 +00:00
if (category && category->get_first_child() == nullptr) {
Proper function/property selection in visual script editing for property. This one has an ordered list, built-in description, search, etc.
2016-08-23 22:29:07 +00:00
memdelete(category); //old category was unused
}
}
Improve TreeItem API and allow to move nodes
2021-03-07 20:07:30 +00:00
get_ok_button()->set_disabled(root->get_first_child() == nullptr);
Proper function/property selection in visual script editing for property. This one has an ordered list, built-in description, search, etc.
2016-08-23 22:29:07 +00:00
}
void PropertySelector::_confirmed() {
TreeItem *ti = search_options->get_selected();
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
if (!ti) {
Proper function/property selection in visual script editing for property. This one has an ordered list, built-in description, search, etc.
2016-08-23 22:29:07 +00:00
return;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
}
Optimize StringName usage * Added a new macro SNAME() that constructs and caches a local stringname. * Subsequent usages use the cached version. * Since these use a global static variable, a second refcounter of static usages need to be kept for cleanup time. * Replaced all theme usages by this new macro. * Replace all signal emission usages by this new macro. * Replace all call_deferred usages by this new macro. This is part of ongoing work to optimize GUI and the editor.
2021-07-17 21:22:52 +00:00
emit_signal(SNAME("selected"), ti->get_metadata(0));
Proper function/property selection in visual script editing for property. This one has an ordered list, built-in description, search, etc.
2016-08-23 22:29:07 +00:00
hide();
}
void PropertySelector::_item_selected() {
Making bits of docs appear in different dialogues is made easier with EditorHelpBit
2016-08-24 02:15:16 +00:00
help_bit->set_text("");
Proper function/property selection in visual script editing for property. This one has an ordered list, built-in description, search, etc.
2016-08-23 22:29:07 +00:00
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
TreeItem *item = search_options->get_selected();
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
if (!item) {
Proper function/property selection in visual script editing for property. This one has an ordered list, built-in description, search, etc.
2016-08-23 22:29:07 +00:00
return;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
}
Proper function/property selection in visual script editing for property. This one has an ordered list, built-in description, search, etc.
2016-08-23 22:29:07 +00:00
String name = item->get_metadata(0);
String class_type;
Changed some code showed in LGTM and Coverage
2019-07-20 06:09:57 +00:00
if (type != Variant::NIL) {
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
class_type = Variant::get_type_name(type);
Replace String comparisons with "", String() to is_empty() Also: - Adds two stress tests to test_string.h - Changes to .empty() on std::strings
2021-12-09 09:42:46 +00:00
} else if (!base_type.is_empty()) {
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
class_type = base_type;
Make property description in the animation editor actually show it
2021-08-08 21:49:43 +00:00
} else if (instance) {
class_type = instance->get_class();
Proper function/property selection in visual script editing for property. This one has an ordered list, built-in description, search, etc.
2016-08-23 22:29:07 +00:00
}
String text;
Revamp how documentation tooltips work
2023-09-21 02:54:51 +00:00
while (!class_type.is_empty()) {
text = properties ? help_bit->get_property_description(class_type, name) : help_bit->get_method_description(class_type, name);
if (!text.is_empty()) {
break;
Proper function/property selection in visual script editing for property. This one has an ordered list, built-in description, search, etc.
2016-08-23 22:29:07 +00:00
}
Revamp how documentation tooltips work
2023-09-21 02:54:51 +00:00
// It may be from a parent class, keep looking.
class_type = ClassDB::get_parent_class(class_type);
Proper function/property selection in visual script editing for property. This one has an ordered list, built-in description, search, etc.
2016-08-23 22:29:07 +00:00
}
Replace String comparisons with "", String() to is_empty() Also: - Adds two stress tests to test_string.h - Changes to .empty() on std::strings
2021-12-09 09:42:46 +00:00
if (!text.is_empty()) {
Make property description in the animation editor actually show it
2021-08-08 21:49:43 +00:00
// Display both property name and description, since the help bit may be displayed
// far away from the location (especially if the dialog was resized to be taller).
help_bit->set_text(vformat("[b]%s[/b]: %s", name, text));
help_bit->get_rich_text()->set_self_modulate(Color(1, 1, 1, 1));
} else {
// Use nested `vformat()` as translators shouldn't interfere with BBCode tags.
help_bit->set_text(vformat(TTR("No description available for %s."), vformat("[b]%s[/b]", name)));
help_bit->get_rich_text()->set_self_modulate(Color(1, 1, 1, 0.5));
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
}
Proper function/property selection in visual script editing for property. This one has an ordered list, built-in description, search, etc.
2016-08-23 22:29:07 +00:00
}
Signals: Port more uses of connect_compat Those were problematic as they call a method of their parent class, but callable_mp does not allow that unless it's public. To solve it, we declare a local class that calls the parent class' method, which now needs to be protected to be accessible in the derived class.
2020-02-27 21:49:16 +00:00
void PropertySelector::_hide_requested() {
Working multiple window support, including editor
2020-03-06 17:00:16 +00:00
_cancel_pressed(); // From AcceptDialog.
Signals: Port more uses of connect_compat Those were problematic as they call a method of their parent class, but callable_mp does not allow that unless it's public. To solve it, we declare a local class that calls the parent class' method, which now needs to be protected to be accessible in the derived class.
2020-02-27 21:49:16 +00:00
}
Proper function/property selection in visual script editing for property. This one has an ordered list, built-in description, search, etc.
2016-08-23 22:29:07 +00:00
void PropertySelector::_notification(int p_what) {
Convert _notification methods to switch - Chunk C
2022-02-16 14:17:55 +00:00
switch (p_what) {
case NOTIFICATION_ENTER_TREE: {
connect("confirmed", callable_mp(this, &PropertySelector::_confirmed));
} break;
case NOTIFICATION_EXIT_TREE: {
disconnect("confirmed", callable_mp(this, &PropertySelector::_confirmed));
} break;
Proper function/property selection in visual script editing for property. This one has an ordered list, built-in description, search, etc.
2016-08-23 22:29:07 +00:00
}
}
Many fixes to visual script, changed virtuals override for a proper selector.
2017-09-12 10:58:18 +00:00
void PropertySelector::select_method_from_base_type(const String &p_base, const String &p_current, bool p_virtuals_only) {
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
base_type = p_base;
selected = p_current;
type = Variant::NIL;
ObjectID converted to a structure, fixes many bugs where used incorrectly as 32 bits.
2020-02-12 17:24:06 +00:00
script = ObjectID();
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
properties = false;
Replace NULL with nullptr
2020-04-01 23:20:12 +00:00
instance = nullptr;
Many fixes to visual script, changed virtuals override for a proper selector.
2017-09-12 10:58:18 +00:00
virtuals_only = p_virtuals_only;
Proper function/property selection in visual script editing for property. This one has an ordered list, built-in description, search, etc.
2016-08-23 22:29:07 +00:00
popup_centered_ratio(0.6);
search_box->set_text("");
search_box->grab_focus();
_update_search();
}
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
void PropertySelector::select_method_from_script(const Ref<Script> &p_script, const String &p_current) {
ERR_FAIL_COND(p_script.is_null());
base_type = p_script->get_instance_base_type();
selected = p_current;
type = Variant::NIL;
Makes all Godot API's methods Lower Case
2017-08-07 10:17:31 +00:00
script = p_script->get_instance_id();
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
properties = false;
Replace NULL with nullptr
2020-04-01 23:20:12 +00:00
instance = nullptr;
Many fixes to visual script, changed virtuals override for a proper selector.
2017-09-12 10:58:18 +00:00
virtuals_only = false;
Proper function/property selection in visual script editing for property. This one has an ordered list, built-in description, search, etc.
2016-08-23 22:29:07 +00:00
popup_centered_ratio(0.6);
search_box->set_text("");
search_box->grab_focus();
_update_search();
}
Style: Enforce separation line between function definitions I couldn't find a tool that enforces it, so I went the manual route: ``` find -name "thirdparty" -prune \ -o -name "*.cpp" -o -name "*.h" -o -name "*.m" -o -name "*.mm" \ -o -name "*.glsl" > files perl -0777 -pi -e 's/\n}\n([^#])/\n}\n\n\1/g' $(cat files) misc/scripts/fix_style.sh -c ``` This adds a newline after all `}` on the first column, unless they are followed by `#` (typically `#endif`). This leads to having lots of places with two lines between function/class definitions, but clang-format then fixes it as we enforce max one line of separation. This doesn't fix potential occurrences of function definitions which are indented (e.g. for a helper class defined in a .cpp), but it's better than nothing. Also can't be made to run easily on CI/hooks so we'll have to be careful with new code. Part of #33027.
2020-05-14 12:29:06 +00:00
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
void PropertySelector::select_method_from_basic_type(Variant::Type p_type, const String &p_current) {
ERR_FAIL_COND(p_type == Variant::NIL);
base_type = "";
selected = p_current;
type = p_type;
ObjectID converted to a structure, fixes many bugs where used incorrectly as 32 bits.
2020-02-12 17:24:06 +00:00
script = ObjectID();
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
properties = false;
Replace NULL with nullptr
2020-04-01 23:20:12 +00:00
instance = nullptr;
Many fixes to visual script, changed virtuals override for a proper selector.
2017-09-12 10:58:18 +00:00
virtuals_only = false;
Proper function/property selection in visual script editing for property. This one has an ordered list, built-in description, search, etc.
2016-08-23 22:29:07 +00:00
popup_centered_ratio(0.6);
search_box->set_text("");
search_box->grab_focus();
_update_search();
}
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
void PropertySelector::select_method_from_instance(Object *p_instance, const String &p_current) {
base_type = p_instance->get_class();
selected = p_current;
type = Variant::NIL;
ObjectID converted to a structure, fixes many bugs where used incorrectly as 32 bits.
2020-02-12 17:24:06 +00:00
script = ObjectID();
Proper function/property selection in visual script editing for property. This one has an ordered list, built-in description, search, etc.
2016-08-23 22:29:07 +00:00
{
Ref<Script> scr = p_instance->get_script();
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
if (scr.is_valid()) {
Makes all Godot API's methods Lower Case
2017-08-07 10:17:31 +00:00
script = scr->get_instance_id();
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 14:41:43 +00:00
}
Proper function/property selection in visual script editing for property. This one has an ordered list, built-in description, search, etc.
2016-08-23 22:29:07 +00:00
}
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
properties = false;
Replace NULL with nullptr
2020-04-01 23:20:12 +00:00
instance = nullptr;
Many fixes to visual script, changed virtuals override for a proper selector.
2017-09-12 10:58:18 +00:00
virtuals_only = false;
Proper function/property selection in visual script editing for property. This one has an ordered list, built-in description, search, etc.
2016-08-23 22:29:07 +00:00
popup_centered_ratio(0.6);
search_box->set_text("");
search_box->grab_focus();
_update_search();
}
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
void PropertySelector::select_property_from_base_type(const String &p_base, const String &p_current) {
base_type = p_base;
selected = p_current;
type = Variant::NIL;
ObjectID converted to a structure, fixes many bugs where used incorrectly as 32 bits.
2020-02-12 17:24:06 +00:00
script = ObjectID();
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
properties = true;
Replace NULL with nullptr
2020-04-01 23:20:12 +00:00
instance = nullptr;
Many fixes to visual script, changed virtuals override for a proper selector.
2017-09-12 10:58:18 +00:00
virtuals_only = false;
Proper function/property selection in visual script editing for property. This one has an ordered list, built-in description, search, etc.
2016-08-23 22:29:07 +00:00
popup_centered_ratio(0.6);
search_box->set_text("");
search_box->grab_focus();
_update_search();
}
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
void PropertySelector::select_property_from_script(const Ref<Script> &p_script, const String &p_current) {
ERR_FAIL_COND(p_script.is_null());
More visual script work -Block switches to 2d/3d editor if editing visual script -Added cast node in flow control -Added ability to do RPC in visual script -Comment nodes -Fix bug with inverted cable in connecting backwards -Copy and paste nodes, including from different scripts
2016-08-25 20:45:20 +00:00
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
base_type = p_script->get_instance_base_type();
selected = p_current;
type = Variant::NIL;
Makes all Godot API's methods Lower Case
2017-08-07 10:17:31 +00:00
script = p_script->get_instance_id();
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
properties = true;
Replace NULL with nullptr
2020-04-01 23:20:12 +00:00
instance = nullptr;
Many fixes to visual script, changed virtuals override for a proper selector.
2017-09-12 10:58:18 +00:00
virtuals_only = false;
Proper function/property selection in visual script editing for property. This one has an ordered list, built-in description, search, etc.
2016-08-23 22:29:07 +00:00
popup_centered_ratio(0.6);
search_box->set_text("");
search_box->grab_focus();
_update_search();
}
PropertyEditor: Fix display of property doc in tooltip
2017-12-09 21:07:45 +00:00
Removal of InputEvent as built-in Variant type.. this might cause bugs I haven't found yet..
2017-05-20 15:38:03 +00:00
void PropertySelector::select_property_from_basic_type(Variant::Type p_type, const String &p_current) {
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
ERR_FAIL_COND(p_type == Variant::NIL);
base_type = "";
selected = p_current;
type = p_type;
ObjectID converted to a structure, fixes many bugs where used incorrectly as 32 bits.
2020-02-12 17:24:06 +00:00
script = ObjectID();
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
properties = true;
Replace NULL with nullptr
2020-04-01 23:20:12 +00:00
instance = nullptr;
Many fixes to visual script, changed virtuals override for a proper selector.
2017-09-12 10:58:18 +00:00
virtuals_only = false;
Proper function/property selection in visual script editing for property. This one has an ordered list, built-in description, search, etc.
2016-08-23 22:29:07 +00:00
popup_centered_ratio(0.6);
search_box->set_text("");
search_box->grab_focus();
_update_search();
}
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
void PropertySelector::select_property_from_instance(Object *p_instance, const String &p_current) {
base_type = "";
selected = p_current;
type = Variant::NIL;
ObjectID converted to a structure, fixes many bugs where used incorrectly as 32 bits.
2020-02-12 17:24:06 +00:00
script = ObjectID();
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
properties = true;
instance = p_instance;
Many fixes to visual script, changed virtuals override for a proper selector.
2017-09-12 10:58:18 +00:00
virtuals_only = false;
Proper function/property selection in visual script editing for property. This one has an ordered list, built-in description, search, etc.
2016-08-23 22:29:07 +00:00
popup_centered_ratio(0.6);
search_box->set_text("");
search_box->grab_focus();
_update_search();
}
Entirely new (and much improved) animation editor.
2018-06-07 15:46:14 +00:00
void PropertySelector::set_type_filter(const Vector<Variant::Type> &p_type_filter) {
type_filter = p_type_filter;
}
Proper function/property selection in visual script editing for property. This one has an ordered list, built-in description, search, etc.
2016-08-23 22:29:07 +00:00
void PropertySelector::_bind_methods() {
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
ADD_SIGNAL(MethodInfo("selected", PropertyInfo(Variant::STRING, "name")));
Proper function/property selection in visual script editing for property. This one has an ordered list, built-in description, search, etc.
2016-08-23 22:29:07 +00:00
}
PropertySelector::PropertySelector() {
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
VBoxContainer *vbc = memnew(VBoxContainer);
Proper function/property selection in visual script editing for property. This one has an ordered list, built-in description, search, etc.
2016-08-23 22:29:07 +00:00
add_child(vbc);
Removed the set_child_rect() in AcceptDialog. AcceptDialog now works as a container!
2017-01-10 04:49:55 +00:00
//set_child_rect(vbc);
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
search_box = memnew(LineEdit);
vbc->add_margin_child(TTR("Search:"), search_box);
Signals: Port connect calls to use callable_mp Remove now unnecessary bindings of signal callbacks in the public API. There might be some false positives that need rebinding if they were meant to be public. No regular expressions were harmed in the making of this commit. (Nah, just kidding.)
2020-02-21 17:28:45 +00:00
search_box->connect("text_changed", callable_mp(this, &PropertySelector::_text_changed));
search_box->connect("gui_input", callable_mp(this, &PropertySelector::_sbox_input));
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
search_options = memnew(Tree);
vbc->add_margin_child(TTR("Matches:"), search_options, true);
Add ok_button_text to AcceptDialog and cancel_button_text to ConfirmationDialog
2022-07-08 00:31:19 +00:00
set_ok_button_text(TTR("Open"));
Rename AcceptDialog get_ok() to get_ok_button() Also renames: - AcceptDialog add_cancel() to add_cancel_button() - ConfirmationDiaglog get_cancel() to get_cancel_button()
2020-12-14 18:37:30 +00:00
get_ok_button()->set_disabled(true);
Proper function/property selection in visual script editing for property. This one has an ordered list, built-in description, search, etc.
2016-08-23 22:29:07 +00:00
register_text_enter(search_box);
set_hide_on_ok(false);
Signals: Port connect calls to use callable_mp Remove now unnecessary bindings of signal callbacks in the public API. There might be some false positives that need rebinding if they were meant to be public. No regular expressions were harmed in the making of this commit. (Nah, just kidding.)
2020-02-21 17:28:45 +00:00
search_options->connect("item_activated", callable_mp(this, &PropertySelector::_confirmed));
search_options->connect("cell_selected", callable_mp(this, &PropertySelector::_item_selected));
Proper function/property selection in visual script editing for property. This one has an ordered list, built-in description, search, etc.
2016-08-23 22:29:07 +00:00
search_options->set_hide_root(true);
search_options->set_hide_folding(true);
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 15:44:50 +00:00
help_bit = memnew(EditorHelpBit);
vbc->add_margin_child(TTR("Description:"), help_bit);
Clamps the height of description text for property selectors
2023-10-21 18:29:17 +00:00
help_bit->get_rich_text()->set_fit_content(false);
help_bit->get_rich_text()->set_custom_minimum_size(Size2(help_bit->get_rich_text()->get_minimum_size().x, 135 * EDSCALE));
Signals: Port more uses of connect_compat Those were problematic as they call a method of their parent class, but callable_mp does not allow that unless it's public. To solve it, we declare a local class that calls the parent class' method, which now needs to be protected to be accessible in the derived class.
2020-02-27 21:49:16 +00:00
help_bit->connect("request_hide", callable_mp(this, &PropertySelector::_hide_requested));
Proper function/property selection in visual script editing for property. This one has an ordered list, built-in description, search, etc.
2016-08-23 22:29:07 +00:00
}
Reference in New Issue Copy Permalink