godotengine
/
godot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
godot/drivers/spirv-reflect/SCsub

18 lines
374 B
Plaintext
Raw Normal View History

Replaced GLSLang reflection by SPIRV-Reflect, eventually allowing to move GLSLang out.
2019-07-28 16:42:15 +00:00
#!/usr/bin/env python
SCons: Format buildsystem files with psf/black Configured for a max line length of 120 characters. psf/black is very opinionated and purposely doesn't leave much room for configuration. The output is mostly OK so that should be fine for us, but some things worth noting: - Manually wrapped strings will be reflowed, so by using a line length of 120 for the sake of preserving readability for our long command calls, it also means that some manually wrapped strings are back on the same line and should be manually merged again. - Code generators using string concatenation extensively look awful, since black puts each operand on a single line. We need to refactor these generators to use more pythonic string formatting, for which many options are available (`%`, `format` or f-strings). - CI checks and a pre-commit hook will be added to ensure that future buildsystem changes are well-formatted.
2020-03-30 06:28:32 +00:00
Import("env")
Replaced GLSLang reflection by SPIRV-Reflect, eventually allowing to move GLSLang out.
2019-07-28 16:42:15 +00:00
SCons: Add explicit dependencies on thirdparty code in cloned env Since we clone the environments to build thirdparty code, we don't get an explicit dependency on the build objects produced by that environment. So when we update thirdparty code, Godot code using it is not necessarily rebuilt (I think it is for changed headers, but not for changed .c/.cpp files), which can lead to an invalid compilation output (linking old Godot .o files with a newer, potentially ABI breaking version of thirdparty code). This was only seen as really problematic with bullet updates (leading to crashes when rebuilding Godot after a bullet update without cleaning .o files), but it's safer to fix it everywhere, even if it's a LOT of hacky boilerplate.
2020-12-17 15:01:36 +00:00
# Thirdparty source files
Replaced GLSLang reflection by SPIRV-Reflect, eventually allowing to move GLSLang out.
2019-07-28 16:42:15 +00:00
thirdparty_dir = "#thirdparty/spirv-reflect/"
thirdparty_sources = [
SCons: Format buildsystem files with psf/black Configured for a max line length of 120 characters. psf/black is very opinionated and purposely doesn't leave much room for configuration. The output is mostly OK so that should be fine for us, but some things worth noting: - Manually wrapped strings will be reflowed, so by using a line length of 120 for the sake of preserving readability for our long command calls, it also means that some manually wrapped strings are back on the same line and should be manually merged again. - Code generators using string concatenation extensively look awful, since black puts each operand on a single line. We need to refactor these generators to use more pythonic string formatting, for which many options are available (`%`, `format` or f-strings). - CI checks and a pre-commit hook will be added to ensure that future buildsystem changes are well-formatted.
2020-03-30 06:28:32 +00:00
"spirv_reflect.c",
Replaced GLSLang reflection by SPIRV-Reflect, eventually allowing to move GLSLang out.
2019-07-28 16:42:15 +00:00
]
Fix various GCC compilation warnings after Vulkan merge Part of #36132.
2020-02-13 14:53:32 +00:00
Replaced GLSLang reflection by SPIRV-Reflect, eventually allowing to move GLSLang out.
2019-07-28 16:42:15 +00:00
thirdparty_sources = [thirdparty_dir + file for file in thirdparty_sources]
SCons: Add explicit dependencies on thirdparty code in cloned env Since we clone the environments to build thirdparty code, we don't get an explicit dependency on the build objects produced by that environment. So when we update thirdparty code, Godot code using it is not necessarily rebuilt (I think it is for changed headers, but not for changed .c/.cpp files), which can lead to an invalid compilation output (linking old Godot .o files with a newer, potentially ABI breaking version of thirdparty code). This was only seen as really problematic with bullet updates (leading to crashes when rebuilding Godot after a bullet update without cleaning .o files), but it's safer to fix it everywhere, even if it's a LOT of hacky boilerplate.
2020-12-17 15:01:36 +00:00
env_thirdparty = env.Clone()
env_thirdparty.disable_warnings()
Replaced GLSLang reflection by SPIRV-Reflect, eventually allowing to move GLSLang out.
2019-07-28 16:42:15 +00:00
SCons: Add explicit dependencies on thirdparty code in cloned env Since we clone the environments to build thirdparty code, we don't get an explicit dependency on the build objects produced by that environment. So when we update thirdparty code, Godot code using it is not necessarily rebuilt (I think it is for changed headers, but not for changed .c/.cpp files), which can lead to an invalid compilation output (linking old Godot .o files with a newer, potentially ABI breaking version of thirdparty code). This was only seen as really problematic with bullet updates (leading to crashes when rebuilding Godot after a bullet update without cleaning .o files), but it's safer to fix it everywhere, even if it's a LOT of hacky boilerplate.
2020-12-17 15:01:36 +00:00
env_thirdparty.add_source_files(env.drivers_sources, thirdparty_sources)