From 2b97020543a53cc904231f32b25f403933b815ac Mon Sep 17 00:00:00 2001 From: Haoyu Qiu Date: Fri, 8 Apr 2022 09:31:19 +0800 Subject: [PATCH] Disable Open in Inspector when there is no animation --- editor/plugins/animation_player_editor_plugin.cpp | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/editor/plugins/animation_player_editor_plugin.cpp b/editor/plugins/animation_player_editor_plugin.cpp index 2081edca253..17a1bd1048c 100644 --- a/editor/plugins/animation_player_editor_plugin.cpp +++ b/editor/plugins/animation_player_editor_plugin.cpp @@ -783,6 +783,7 @@ void AnimationPlayerEditor::_update_player() { ITEM_CHECK_DISABLED(TOOL_RENAME_ANIM); ITEM_CHECK_DISABLED(TOOL_EDIT_TRANSITIONS); ITEM_CHECK_DISABLED(TOOL_REMOVE_ANIM); + ITEM_CHECK_DISABLED(TOOL_EDIT_RESOURCE); #undef ITEM_CHECK_DISABLED @@ -1079,15 +1080,9 @@ void AnimationPlayerEditor::_animation_tool_menu(int p_option) { _animation_remove(); } break; case TOOL_EDIT_RESOURCE: { - if (!animation->has_selectable_items()) { - error_dialog->set_text(TTR("No animation to edit!")); - error_dialog->popup_centered(); - return; + if (anim.is_valid()) { + EditorNode::get_singleton()->edit_resource(anim); } - - String current2 = animation->get_item_text(animation->get_selected()); - Ref anim2 = player->get_animation(current2); - EditorNode::get_singleton()->edit_resource(anim2); } break; } }