godotengine/godot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge pull request #59123 from Snowapril/fix-nan-specular-highlight

Browse Source 
Fix `D_GGX` code which can cause `divide-by-zero`
This commit is contained in:
Rémi Verschelde 2022-03-14 07:21:16 +01:00 committed by GitHub
commit 000ff82071
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
servers/rendering/renderer_rd/shaders/scene_forward_lights_inc.glsl
View File

@ -1,9 +1,9 @@
// Functions related to lighting // Functions related to lighting
float D_GGX(float cos_theta_m, float alpha) { float D_GGX(float cos_theta_m, float alpha) {
float alpha2 = alpha * alpha; float a = cos_theta_m * alpha;
float d = 1.0 + (alpha2 - 1.0) * cos_theta_m * cos_theta_m; float k = alpha / (1.0 - cos_theta_m * cos_theta_m + a * a);
return alpha2 / (M_PI * d * d); return k * k * (1.0 / M_PI);
} }
// From Earl Hammon, Jr. "PBR Diffuse Lighting for GGX+Smith Microsurfaces" https://www.gdcvault.com/play/1024478/PBR-Diffuse-Lighting-for-GGX // From Earl Hammon, Jr. "PBR Diffuse Lighting for GGX+Smith Microsurfaces" https://www.gdcvault.com/play/1024478/PBR-Diffuse-Lighting-for-GGX