godotengine/godot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge pull request #91368 from raulsntos/dotnet/must-be-variant-dynamic

Browse Source 
C#: Ignore late bound methods in MustBeVariantAnalyzer
This commit is contained in:
Rémi Verschelde 2024-05-01 09:55:21 +02:00
commit 0e0ef3cd69
No known key found for this signature in database
GPG Key ID: C3336907360768E1
2 changed files with 18 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
modules/mono/editor/Godot.NET.Sdk/Godot.SourceGenerators.Tests/TestData/Sources/MustBeVariant.GD0301.cs
View File

@ -66,6 +66,12 @@ public class MustBeVariantGD0301
Method<Rid[]>(); Method<Rid[]>();
} }
public void MethodCallDynamic()
{
dynamic self = this;
self.Method<object>();
}
public void Method<[MustBeVariant] T>() public void Method<[MustBeVariant] T>()
{ {
} }

14
modules/mono/editor/Godot.NET.Sdk/Godot.SourceGenerators/MustBeVariantAnalyzer.cs
View File

@ -50,8 +50,18 @@ namespace Godot.SourceGenerators
var typeSymbol = sm.GetSymbolInfo(typeSyntax).Symbol as ITypeSymbol; var typeSymbol = sm.GetSymbolInfo(typeSyntax).Symbol as ITypeSymbol;
Helper.ThrowIfNull(typeSymbol); Helper.ThrowIfNull(typeSymbol);
var parentSymbol = sm.GetSymbolInfo(parentSyntax).Symbol; var parentSymbolInfo = sm.GetSymbolInfo(parentSyntax);
Helper.ThrowIfNull(parentSymbol); var parentSymbol = parentSymbolInfo.Symbol;
if (parentSymbol == null)
{
if (parentSymbolInfo.CandidateReason == CandidateReason.LateBound)
{
// Invocations on dynamic are late bound so we can't retrieve the symbol.
continue;
}
Helper.ThrowIfNull(parentSymbol);
}
if (!ShouldCheckTypeArgument(context, parentSyntax, parentSymbol, typeSyntax, typeSymbol, i)) if (!ShouldCheckTypeArgument(context, parentSyntax, parentSymbol, typeSyntax, typeSymbol, i))
{ {