From 15315f118ccd0a462eafa01801570c0dd887ca4d Mon Sep 17 00:00:00 2001 From: Georg Wacker Date: Mon, 21 Oct 2019 16:52:45 +0200 Subject: [PATCH] Fix control node transform animation jitter with pivot offset The workaround for moving the pivot is not needed anymore, in fact it causes all transforms applied to control nodes to jitter while animating (if a pivot offset is set). This can be observed via AnimationPlayer and Tween. The fix is to remove the obsolete workaround that causes this bug. Fixes #28804 (cherry picked from commit dfb7d46a2aaf9bef2c7dd067e699e70291062fb6) --- scene/gui/control.cpp | 5 ----- 1 file changed, 5 deletions(-) diff --git a/scene/gui/control.cpp b/scene/gui/control.cpp index ae48a1356e6..4c70bd1d394 100644 --- a/scene/gui/control.cpp +++ b/scene/gui/control.cpp @@ -462,11 +462,6 @@ void Control::_update_canvas_item_transform() { Transform2D xform = _get_internal_transform(); xform[2] += get_position(); - // We use a little workaround to avoid flickering when moving the pivot with _edit_set_pivot() - if (is_inside_tree() && Math::abs(Math::sin(data.rotation * 4.0f)) < 0.00001f && get_viewport()->is_snap_controls_to_pixels_enabled()) { - xform[2] = xform[2].round(); - } - VisualServer::get_singleton()->canvas_item_set_transform(get_canvas_item(), xform); }