godotengine/godot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Prevent crash when clicking Mesh in MeshInstance when is scene root

Browse Source
This commit is contained in:
hilfazer 2021-02-26 19:28:09 +01:00
parent cb29e6c49c
commit 1810654369
2 changed files with 9 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
editor/plugins/node_3d_editor_plugin.cpp
View File

@ -534,7 +534,10 @@ ObjectID Node3DEditorViewport::_select_ray(const Point2 &p_pos, bool p_append, b
} }
if (dist < closest_dist) { if (dist < closest_dist) {
item = edited_scene->get_deepest_editable_node(Object::cast_to<Node>(spat)); item = Object::cast_to<Node>(spat);
if (item != edited_scene) {
item = edited_scene->get_deepest_editable_node(item);
}
closest = item->get_instance_id(); closest = item->get_instance_id();
closest_dist = dist; closest_dist = dist;
@ -693,7 +696,10 @@ void Node3DEditorViewport::_select_region() {
continue; continue;
} }
Node *item = edited_scene->get_deepest_editable_node(Object::cast_to<Node>(sp)); Node *item = Object::cast_to<Node>(sp);
if (item != edited_scene) {
item = edited_scene->get_deepest_editable_node(item);
}
// Replace the node by the group if grouped // Replace the node by the group if grouped
if (item->is_class("Node3D")) { if (item->is_class("Node3D")) {

2
scene/main/node.cpp
View File

@ -1976,7 +1976,7 @@ bool Node::is_editable_instance(const Node *p_node) const {
Node *Node::get_deepest_editable_node(Node *p_start_node) const { Node *Node::get_deepest_editable_node(Node *p_start_node) const {
ERR_FAIL_NULL_V(p_start_node, nullptr); ERR_FAIL_NULL_V(p_start_node, nullptr);
ERR_FAIL_COND_V(!is_a_parent_of(p_start_node), nullptr); ERR_FAIL_COND_V(!is_a_parent_of(p_start_node), p_start_node);
Node const *iterated_item = p_start_node; Node const *iterated_item = p_start_node;
Node *node = p_start_node; Node *node = p_start_node;