godotengine/godot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix GDScript parser crash on 'dollar mixed with assignment' expression

Browse Source 
fixes #53696
This commit is contained in:
Pawel Lampe 2021-11-21 21:17:35 +01:00
parent ed02b8af59
commit 1a15a3adf6
3 changed files with 7 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
modules/gdscript/gdscript_parser.cpp
View File

@ -2420,6 +2420,9 @@ GDScriptParser::ExpressionNode *GDScriptParser::parse_assignment(ExpressionNode
push_error("Assignment is not allowed inside an expression.");
return parse_expression(false); // Return the following expression.
}
if (p_previous_operand == nullptr) {
return parse_expression(false); // Return the following expression.
}
#ifdef DEBUG_ENABLED
VariableNode *source_variable = nullptr;

2
modules/gdscript/tests/scripts/parser/errors/dollar-assignment-bug-53696.gd Normal file
View File

@ -0,0 +1,2 @@
func test():
$=$

2
modules/gdscript/tests/scripts/parser/errors/dollar-assignment-bug-53696.out Normal file
View File

@ -0,0 +1,2 @@
GDTEST_PARSER_ERROR
Expect node path as string or identifier after "$".