godotengine/godot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge pull request #67079 from timothyqiu/main-caret

Browse Source 
Don't allow removing `TextEdit`'s main caret
This commit is contained in:
Rémi Verschelde 2022-10-10 10:03:16 +02:00
commit 1c3a63a970
2 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
scene/gui/text_edit.cpp
View File

@ -4380,7 +4380,7 @@ int TextEdit::add_caret(int p_line, int p_col) {
}
void TextEdit::remove_caret(int p_caret) {
ERR_FAIL_COND(carets.size() <= 0);
ERR_FAIL_COND_MSG(carets.size() <= 1, "The main caret should not be removed.");
ERR_FAIL_INDEX(p_caret, carets.size());
carets.remove_at(p_caret);
caret_index_edit_dirty = true;

5
tests/scene/test_text_edit.h
View File

@ -3321,6 +3321,11 @@ TEST_CASE("[SceneTree][TextEdit] muiticaret") {
CHECK(text_edit->get_caret_count() == 1);
CHECK(text_edit->get_caret_line(0) == 0);
CHECK(text_edit->get_caret_column(0) == 1);
ERR_PRINT_OFF;
text_edit->remove_caret(0);
CHECK(text_edit->get_caret_count() == 1);
ERR_PRINT_ON;
}
SUBCASE("[TextEdit] caret index edit order") {