godotengine
/
godot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fixed shuffling editor help tabs 

The indexes for the ScriptEditorItemData entries were not getting
updated after sorting. This would cause a page to be open but with a
different tab selected. Whenever _update_script_names was called next,
it would correct this indexing. Now we correct it immediately following
the tab sort.

(cherry picked from commit fe53c1b0bd)
This commit is contained in:
Tom Evans 2020-04-26 12:23:00 -05:00 committed by Rémi Verschelde
parent 6bb87d7d23
commit 1f970670b7
1 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
editor/plugins/script_editor_plugin.cpp
View File

@ -1922,6 +1922,10 @@ void ScriptEditor::_update_script_names() {
if (new_cur_tab == -1 && sedata[i].index == cur_tab) { if (new_cur_tab == -1 && sedata[i].index == cur_tab) {
new_cur_tab = i; new_cur_tab = i;
} }
// Update index of sd entries for sorted order
_ScriptEditorItemData sd = sedata[i];
sd.index = i;
sedata.set(i, sd);
} }
tab_container->set_current_tab(new_prev_tab); tab_container->set_current_tab(new_prev_tab);
tab_container->set_current_tab(new_cur_tab); tab_container->set_current_tab(new_cur_tab);