From 2108019484dc59425d4f354a7a51060bd459fe94 Mon Sep 17 00:00:00 2001
From: Raul Santos <raulsntos@gmail.com>
Date: Sun, 11 Sep 2022 12:34:07 +0200
Subject: [PATCH] Remove redefinition of `notification` method in
 `XRInterfaceExtension`

---
 doc/classes/XRInterfaceExtension.xml  | 7 -------
 servers/xr/xr_interface.h             | 2 --
 servers/xr/xr_interface_extension.cpp | 6 ------
 servers/xr/xr_interface_extension.h   | 3 ---
 4 files changed, 18 deletions(-)

diff --git a/doc/classes/XRInterfaceExtension.xml b/doc/classes/XRInterfaceExtension.xml
index c6b215daa3a..0fe54e947fe 100644
--- a/doc/classes/XRInterfaceExtension.xml
+++ b/doc/classes/XRInterfaceExtension.xml
@@ -141,13 +141,6 @@
 				Returns [code]true[/code] if this interface has been initialized.
 			</description>
 		</method>
-		<method name="_notification" qualifiers="virtual">
-			<return type="void" />
-			<param index="0" name="what" type="int" />
-			<description>
-				Informs the interface of an applicable system notification.
-			</description>
-		</method>
 		<method name="_post_draw_viewport" qualifiers="virtual">
 			<return type="void" />
 			<param index="0" name="render_target" type="RID" />
diff --git a/servers/xr/xr_interface.h b/servers/xr/xr_interface.h
index 86d328d41c8..2960074dd29 100644
--- a/servers/xr/xr_interface.h
+++ b/servers/xr/xr_interface.h
@@ -138,8 +138,6 @@ public:
 	virtual bool start_passthrough() { return false; }
 	virtual void stop_passthrough() {}
 
-	virtual void notification(int p_what){};
-
 	XRInterface();
 	~XRInterface();
 
diff --git a/servers/xr/xr_interface_extension.cpp b/servers/xr/xr_interface_extension.cpp
index 89752b30178..2142ecd2629 100644
--- a/servers/xr/xr_interface_extension.cpp
+++ b/servers/xr/xr_interface_extension.cpp
@@ -58,8 +58,6 @@ void XRInterfaceExtension::_bind_methods() {
 	GDVIRTUAL_BIND(_post_draw_viewport, "render_target", "screen_rect");
 	GDVIRTUAL_BIND(_end_frame);
 
-	GDVIRTUAL_BIND(_notification, "what");
-
 	/** input and output **/
 
 	GDVIRTUAL_BIND(_get_suggested_tracker_names);
@@ -309,10 +307,6 @@ void XRInterfaceExtension::end_frame() {
 	GDVIRTUAL_CALL(_end_frame);
 }
 
-void XRInterfaceExtension::notification(int p_what) {
-	GDVIRTUAL_CALL(_notification, p_what);
-}
-
 RID XRInterfaceExtension::get_render_target_texture(RID p_render_target) {
 	// In due time this will need to be enhance to return the correct INTERNAL RID for the chosen rendering engine.
 	// So once a GLES driver is implemented we'll return that and the implemented plugin needs to handle this correctly too.
diff --git a/servers/xr/xr_interface_extension.h b/servers/xr/xr_interface_extension.h
index 2235b57cb38..123626864d2 100644
--- a/servers/xr/xr_interface_extension.h
+++ b/servers/xr/xr_interface_extension.h
@@ -123,7 +123,6 @@ public:
 	virtual bool pre_draw_viewport(RID p_render_target) override;
 	virtual Vector<BlitToScreen> post_draw_viewport(RID p_render_target, const Rect2 &p_screen_rect) override;
 	virtual void end_frame() override;
-	virtual void notification(int p_what) override;
 
 	GDVIRTUAL0(_process);
 	GDVIRTUAL0(_pre_render);
@@ -131,8 +130,6 @@ public:
 	GDVIRTUAL2(_post_draw_viewport, RID, const Rect2 &);
 	GDVIRTUAL0(_end_frame);
 
-	GDVIRTUAL1(_notification, int);
-
 	/* access to some internals we need */
 	RID get_render_target_texture(RID p_render_target);
 	// RID get_render_target_depth(RID p_render_target);