From 53c01540d917384ac3addb9ea4938c37a10cd043 Mon Sep 17 00:00:00 2001 From: FireForge <67974470+fire-forge@users.noreply.github.com> Date: Fri, 10 Jun 2022 17:33:12 +0800 Subject: [PATCH] Make Input mouse_mode and use_accumulated_input properties Co-authored-by: Haoyu Qiu --- core/os/input.cpp | 4 ++++ core/os/input.h | 1 + doc/classes/Input.xml | 32 +++++++++------------------ doc/classes/InputEventMouseMotion.xml | 2 +- main/input_default.cpp | 4 ++++ main/input_default.h | 1 + 6 files changed, 21 insertions(+), 23 deletions(-) diff --git a/core/os/input.cpp b/core/os/input.cpp index 0de0b781438..ccc576f8797 100644 --- a/core/os/input.cpp +++ b/core/os/input.cpp @@ -103,8 +103,12 @@ void Input::_bind_methods() { ClassDB::bind_method(D_METHOD("set_custom_mouse_cursor", "image", "shape", "hotspot"), &Input::set_custom_mouse_cursor, DEFVAL(CURSOR_ARROW), DEFVAL(Vector2())); ClassDB::bind_method(D_METHOD("parse_input_event", "event"), &Input::parse_input_event); ClassDB::bind_method(D_METHOD("set_use_accumulated_input", "enable"), &Input::set_use_accumulated_input); + ClassDB::bind_method(D_METHOD("is_using_accumulated_input"), &Input::is_using_accumulated_input); ClassDB::bind_method(D_METHOD("flush_buffered_events"), &Input::flush_buffered_events); + ADD_PROPERTY(PropertyInfo(Variant::INT, "mouse_mode"), "set_mouse_mode", "get_mouse_mode"); + ADD_PROPERTY(PropertyInfo(Variant::BOOL, "use_accumulated_input"), "set_use_accumulated_input", "is_using_accumulated_input"); + BIND_ENUM_CONSTANT(MOUSE_MODE_VISIBLE); BIND_ENUM_CONSTANT(MOUSE_MODE_HIDDEN); BIND_ENUM_CONSTANT(MOUSE_MODE_CAPTURED); diff --git a/core/os/input.h b/core/os/input.h index ed12ec654bb..deeb6475568 100644 --- a/core/os/input.h +++ b/core/os/input.h @@ -144,6 +144,7 @@ public: virtual void flush_buffered_events() = 0; virtual bool is_using_input_buffering() = 0; virtual void set_use_input_buffering(bool p_enable) = 0; + virtual bool is_using_accumulated_input() = 0; virtual void set_use_accumulated_input(bool p_enable) = 0; Input(); diff --git a/doc/classes/Input.xml b/doc/classes/Input.xml index 00747287942..39d525c1b19 100644 --- a/doc/classes/Input.xml +++ b/doc/classes/Input.xml @@ -40,7 +40,7 @@ - Sends all input events which are in the current buffer to the game loop. These events may have been buffered as a result of accumulated input ([method set_use_accumulated_input]) or agile input flushing ([member ProjectSettings.input_devices/buffering/agile_event_flushing]). + Sends all input events which are in the current buffer to the game loop. These events may have been buffered as a result of accumulated input ([member use_accumulated_input]) or agile input flushing ([member ProjectSettings.input_devices/buffering/agile_event_flushing]). The engine will already do this itself at key execution points (at least once per frame). However, this can be useful in advanced cases where you want precise control over the timing of event handling. @@ -188,12 +188,6 @@ Returns mouse buttons as a bitmask. If multiple mouse buttons are pressed at the same time, the bits are added together. - - - - Returns the mouse mode. See the constants for more information. - - @@ -363,21 +357,6 @@ [b]Note:[/b] This value can be immediately overwritten by the hardware sensor value on Android and iOS. - - - - - Sets the mouse mode. See the constants for more information. - - - - - - - Enables or disables the accumulation of similar input events sent by the operating system. When input accumulation is enabled, all input events generated during a frame will be merged and emitted when the frame is done rendering. Therefore, this limits the number of input method calls per second to the rendering FPS. - Input accumulation is enabled by default. It can be disabled to get slightly more precise/reactive input at the cost of increased CPU usage. In applications where drawing freehand lines is required, input accumulation should generally be disabled while the user is drawing the line to get results that closely follow the actual input. - - @@ -414,6 +393,15 @@ + + + Controls the mouse mode. See [enum MouseMode] for more information. + + + If [code]true[/code], similar input events sent by the operating system are accumulated. When input accumulation is enabled, all input events generated during a frame will be merged and emitted when the frame is done rendering. Therefore, this limits the number of input method calls per second to the rendering FPS. + Input accumulation can be disabled to get slightly more precise/reactive input at the cost of increased CPU usage. In applications where drawing freehand lines is required, input accumulation should generally be disabled while the user is drawing the line to get results that closely follow the actual input. + + diff --git a/doc/classes/InputEventMouseMotion.xml b/doc/classes/InputEventMouseMotion.xml index 388e144f438..84e2ea24f55 100644 --- a/doc/classes/InputEventMouseMotion.xml +++ b/doc/classes/InputEventMouseMotion.xml @@ -5,7 +5,7 @@ Contains mouse and pen motion information. Supports relative, absolute positions and speed. See [method Node._input]. - [b]Note:[/b] By default, this event is only emitted once per frame rendered at most. If you need more precise input reporting, call [method Input.set_use_accumulated_input] with [code]false[/code] to make events emitted as often as possible. If you use InputEventMouseMotion to draw lines, consider implementing [url=https://en.wikipedia.org/wiki/Bresenham%27s_line_algorithm]Bresenham's line algorithm[/url] as well to avoid visible gaps in lines if the user is moving the mouse quickly. + [b]Note:[/b] By default, this event is only emitted once per frame rendered at most. If you need more precise input reporting, set [member Input.use_accumulated_input] to [code]false[/code] to make events emitted as often as possible. If you use InputEventMouseMotion to draw lines, consider implementing [url=https://en.wikipedia.org/wiki/Bresenham%27s_line_algorithm]Bresenham's line algorithm[/url] as well to avoid visible gaps in lines if the user is moving the mouse quickly. $DOCS_URL/tutorials/inputs/mouse_and_input_coordinates.html diff --git a/main/input_default.cpp b/main/input_default.cpp index e861d4e9f1b..d0cae2f6396 100644 --- a/main/input_default.cpp +++ b/main/input_default.cpp @@ -723,6 +723,10 @@ void InputDefault::set_use_input_buffering(bool p_enable) { use_input_buffering = p_enable; } +bool InputDefault::is_using_accumulated_input() { + return use_accumulated_input; +} + void InputDefault::set_use_accumulated_input(bool p_enable) { use_accumulated_input = p_enable; } diff --git a/main/input_default.h b/main/input_default.h index 0b34a37df88..67dbcd7d270 100644 --- a/main/input_default.h +++ b/main/input_default.h @@ -301,6 +301,7 @@ public: virtual void flush_buffered_events(); virtual bool is_using_input_buffering(); virtual void set_use_input_buffering(bool p_enable); + virtual bool is_using_accumulated_input(); virtual void set_use_accumulated_input(bool p_enable); virtual void release_pressed_events();