From 27dc9fa4c0484ac4421b257d4986ea660fa432e6 Mon Sep 17 00:00:00 2001 From: Per Melin Date: Fri, 2 Feb 2024 16:13:32 +0100 Subject: [PATCH] Fix frame number underflow in visual profiler Unsigned subtraction underflow caused the frame counter to be locked at 2^64 in the visual profiler until debugger/profiler_frame_history_size number of frames had passed. --- editor/debugger/editor_visual_profiler.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/editor/debugger/editor_visual_profiler.cpp b/editor/debugger/editor_visual_profiler.cpp index 4ebed726c55..72f10605895 100644 --- a/editor/debugger/editor_visual_profiler.cpp +++ b/editor/debugger/editor_visual_profiler.cpp @@ -70,7 +70,7 @@ void EditorVisualProfiler::add_frame_metric(const Metric &p_metric) { updating_frame = true; clear_button->set_disabled(false); cursor_metric_edit->set_max(frame_metrics[last_metric].frame_number); - cursor_metric_edit->set_min(MAX(frame_metrics[last_metric].frame_number - frame_metrics.size(), 0u)); + cursor_metric_edit->set_min(MAX(int64_t(frame_metrics[last_metric].frame_number) - frame_metrics.size(), 0)); if (!seeking) { cursor_metric_edit->set_value(frame_metrics[last_metric].frame_number);