godotengine
/
godot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Replace `arguments` keyword with rest parameter

This commit is contained in:
Adam Scott 2024-07-29 15:10:28 -04:00
parent 0e9caa2d9c
commit 27dfbd9c04
No known key found for this signature in database
GPG Key ID: F6BA2A0302E21A77
3 changed files with 9 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
platform/web/js/engine/config.js
View File

@ -194,8 +194,8 @@ const InternalConfig = function (initConfig) { // eslint-disable-line no-unused-
* @ignore * @ignore
* @type {?function(...*)} * @type {?function(...*)}
*/ */
onPrint: function () { onPrint: function (...args) {
console.log.apply(console, Array.from(arguments)); // eslint-disable-line no-console console.log.apply(console, ...args); // eslint-disable-line no-console
}, },
/** /**
* A callback function for handling the standard error stream. This method should usually only be used in debug pages. * A callback function for handling the standard error stream. This method should usually only be used in debug pages.
@ -209,8 +209,8 @@ const InternalConfig = function (initConfig) { // eslint-disable-line no-unused-
* @ignore * @ignore
* @type {?function(...*)} * @type {?function(...*)}
*/ */
onPrintError: function (var_args) { onPrintError: function (...args) {
console.error.apply(console, Array.from(arguments)); // eslint-disable-line no-console console.error.apply(console, ...args); // eslint-disable-line no-console
}, },
}; };

3
platform/web/js/libs/library_godot_javascript_singleton.js
View File

@ -215,7 +215,7 @@ const GodotJSWrapper = {
godot_js_wrapper_create_cb: function (p_ref, p_func) { godot_js_wrapper_create_cb: function (p_ref, p_func) {
const func = GodotRuntime.get_func(p_func); const func = GodotRuntime.get_func(p_func);
let id = 0; let id = 0;
const cb = function () { const cb = function (...args) {
if (!GodotJSWrapper.get_proxied_value(id)) { if (!GodotJSWrapper.get_proxied_value(id)) {
return undefined; return undefined;
} }
@ -223,7 +223,6 @@ const GodotJSWrapper = {
// "godot_js_wrapper_object_set_cb_ret" upon calling the user function. // "godot_js_wrapper_object_set_cb_ret" upon calling the user function.
// This is safe! JavaScript is single threaded (and using it in threads is not a good idea anyway). // This is safe! JavaScript is single threaded (and using it in threads is not a good idea anyway).
GodotJSWrapper.cb_ret = null; GodotJSWrapper.cb_ret = null;
const args = Array.from(arguments);
const argsProxy = new GodotJSWrapper.MyProxy(args); const argsProxy = new GodotJSWrapper.MyProxy(args);
func(p_ref, argsProxy.get_id(), args.length); func(p_ref, argsProxy.get_id(), args.length);
argsProxy.unref(); argsProxy.unref();

8
platform/web/js/libs/library_godot_runtime.js
View File

@ -40,12 +40,12 @@ const GodotRuntime = {
/* /*
* Prints * Prints
*/ */
error: function () { error: function (...args) {
err.apply(null, Array.from(arguments)); // eslint-disable-line no-undef err.apply(null, ...args); // eslint-disable-line no-undef
}, },
print: function () { print: function (...args) {
out.apply(null, Array.from(arguments)); // eslint-disable-line no-undef out.apply(null, ...args); // eslint-disable-line no-undef
}, },
/* /*