godotengine/godot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix a bug with moving dock left and right.

Browse Source 
Fixes #67039

`get_index` counts internal children by default but `move_child` ignores them therefore `move_child` had no effect.

The call to `set_current_tab` is not needed anymore in Godot 4 since the current tab will change when calling `move_child`.
This commit is contained in:
HolonProduction 2022-10-07 19:15:20 +02:00
parent 1baefceaba
commit 301a8fd559
1 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
editor/editor_node.cpp
View File

@ -4678,8 +4678,7 @@ void EditorNode::_dock_move_left() {
if (!current_ctl || !prev_ctl) {
return;
}
dock_slot[dock_popup_selected_idx]->move_child(current_ctl, prev_ctl->get_index());
dock_slot[dock_popup_selected_idx]->set_current_tab(dock_slot[dock_popup_selected_idx]->get_current_tab() - 1);
dock_slot[dock_popup_selected_idx]->move_child(current_ctl, prev_ctl->get_index(false));
dock_select->queue_redraw();
_edit_current();
_save_docks();
@ -4691,8 +4690,7 @@ void EditorNode::_dock_move_right() {
if (!current_ctl || !next_ctl) {
return;
}
dock_slot[dock_popup_selected_idx]->move_child(next_ctl, current_ctl->get_index());
dock_slot[dock_popup_selected_idx]->set_current_tab(dock_slot[dock_popup_selected_idx]->get_current_tab() + 1);
dock_slot[dock_popup_selected_idx]->move_child(next_ctl, current_ctl->get_index(false));
dock_select->queue_redraw();
_edit_current();
_save_docks();