godotengine
/
godot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge pull request #91789 from lawnjelly/fix_tight_light_cull_directional_colinear 

[3.x] Tighter light culling - fix directional lights colinear case
This commit is contained in:
lawnjelly 2024-05-10 10:51:14 +01:00 committed by GitHub
parent 2a347ab867 b09bc22b74
commit 30b025d3d0
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 10 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
servers/visual/visual_server_light_culler.cpp
View File

@ -227,9 +227,11 @@ bool VisualServerLightCuller::add_light_camera_planes_directional(const LightSou
// Create a third point from the light direction.
Vector3 pt2 = pt0 - p_light_source.dir;
// Create plane from 3 points.
Plane p(pt0, pt1, pt2);
add_cull_plane(p);
if (!_is_colinear_tri(pt0, pt1, pt2)) {
// Create plane from 3 points.
Plane p(pt0, pt1, pt2);
add_cull_plane(p);
}
}
// Last to 0 edge.
@ -243,9 +245,11 @@ bool VisualServerLightCuller::add_light_camera_planes_directional(const LightSou
// Create a third point from the light direction.
Vector3 pt2 = pt0 - p_light_source.dir;
// Create plane from 3 points.
Plane p(pt0, pt1, pt2);
add_cull_plane(p);
if (!_is_colinear_tri(pt0, pt1, pt2)) {
// Create plane from 3 points.
Plane p(pt0, pt1, pt2);
add_cull_plane(p);
}
}
#ifdef LIGHT_CULLER_DEBUG_LOGGING