godotengine
/
godot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Improve handling of rendering startup errors

This commit is contained in:
Pedro J. Estébanez 2024-06-28 17:17:20 +02:00
parent 811ce36c60
commit 32d9c93af3
6 changed files with 42 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
platform/android/display_server_android.cpp
View File

@ -607,6 +607,7 @@ DisplayServerAndroid::DisplayServerAndroid(const String &p_rendering_driver, Dis
ERR_PRINT(vformat("Failed to initialize %s context", rendering_driver)); ERR_PRINT(vformat("Failed to initialize %s context", rendering_driver));
memdelete(rendering_context); memdelete(rendering_context);
rendering_context = nullptr; rendering_context = nullptr;
r_error = ERR_UNAVAILABLE;
return; return;
} }
@ -627,6 +628,7 @@ DisplayServerAndroid::DisplayServerAndroid(const String &p_rendering_driver, Dis
ERR_PRINT(vformat("Failed to create %s window.", rendering_driver)); ERR_PRINT(vformat("Failed to create %s window.", rendering_driver));
memdelete(rendering_context); memdelete(rendering_context);
rendering_context = nullptr; rendering_context = nullptr;
r_error = ERR_UNAVAILABLE;
return; return;
} }
@ -635,7 +637,13 @@ DisplayServerAndroid::DisplayServerAndroid(const String &p_rendering_driver, Dis
rendering_context->window_set_vsync_mode(MAIN_WINDOW_ID, p_vsync_mode); rendering_context->window_set_vsync_mode(MAIN_WINDOW_ID, p_vsync_mode);
rendering_device = memnew(RenderingDevice); rendering_device = memnew(RenderingDevice);
rendering_device->initialize(rendering_context, MAIN_WINDOW_ID); if (rendering_device->initialize(rendering_context, MAIN_WINDOW_ID) != OK) {
rendering_device = nullptr;
memdelete(rendering_context);
rendering_context = nullptr;
r_error = ERR_UNAVAILABLE;
return;
}
rendering_device->screen_create(MAIN_WINDOW_ID); rendering_device->screen_create(MAIN_WINDOW_ID);
RendererCompositorRD::make_current(); RendererCompositorRD::make_current();

9
platform/ios/display_server_ios.mm
View File

@ -91,6 +91,7 @@ DisplayServerIOS::DisplayServerIOS(const String &p_rendering_driver, WindowMode
ERR_PRINT(vformat("Failed to initialize %s context", rendering_driver)); ERR_PRINT(vformat("Failed to initialize %s context", rendering_driver));
memdelete(rendering_context); memdelete(rendering_context);
rendering_context = nullptr; rendering_context = nullptr;
r_error = ERR_UNAVAILABLE;
return; return;
} }
@ -107,7 +108,13 @@ DisplayServerIOS::DisplayServerIOS(const String &p_rendering_driver, WindowMode
rendering_context->window_set_vsync_mode(MAIN_WINDOW_ID, p_vsync_mode); rendering_context->window_set_vsync_mode(MAIN_WINDOW_ID, p_vsync_mode);
rendering_device = memnew(RenderingDevice); rendering_device = memnew(RenderingDevice);
rendering_device->initialize(rendering_context, MAIN_WINDOW_ID); if (rendering_device->initialize(rendering_context, MAIN_WINDOW_ID) != OK) {
rendering_device = nullptr;
memdelete(rendering_context);
rendering_context = nullptr;
r_error = ERR_UNAVAILABLE;
return;
}
rendering_device->screen_create(MAIN_WINDOW_ID); rendering_device->screen_create(MAIN_WINDOW_ID);
RendererCompositorRD::make_current(); RendererCompositorRD::make_current();

9
platform/linuxbsd/wayland/display_server_wayland.cpp
View File

@ -1469,7 +1469,14 @@ DisplayServerWayland::DisplayServerWayland(const String &p_rendering_driver, Win
#ifdef RD_ENABLED #ifdef RD_ENABLED
if (rendering_context) { if (rendering_context) {
rendering_device = memnew(RenderingDevice); rendering_device = memnew(RenderingDevice);
rendering_device->initialize(rendering_context, MAIN_WINDOW_ID); if (rendering_device->initialize(rendering_context, MAIN_WINDOW_ID) != OK) {
memdelete(rendering_device);
rendering_device = nullptr;
memdelete(rendering_context);
rendering_context = nullptr;
r_error = ERR_UNAVAILABLE;
return;
}
rendering_device->screen_create(MAIN_WINDOW_ID); rendering_device->screen_create(MAIN_WINDOW_ID);
RendererCompositorRD::make_current(); RendererCompositorRD::make_current();

10
platform/linuxbsd/x11/display_server_x11.cpp
View File

@ -6261,8 +6261,14 @@ DisplayServerX11::DisplayServerX11(const String &p_rendering_driver, WindowMode
#if defined(RD_ENABLED) #if defined(RD_ENABLED)
if (rendering_context) { if (rendering_context) {
rendering_device = memnew(RenderingDevice); if (rendering_device->initialize(rendering_context, MAIN_WINDOW_ID) != OK) {
rendering_device->initialize(rendering_context, MAIN_WINDOW_ID); memdelete(rendering_device);
rendering_device = nullptr;
memdelete(rendering_context);
rendering_context = nullptr;
r_error = ERR_UNAVAILABLE;
return;
}
rendering_device->screen_create(MAIN_WINDOW_ID); rendering_device->screen_create(MAIN_WINDOW_ID);
RendererCompositorRD::make_current(); RendererCompositorRD::make_current();

9
platform/windows/display_server_windows.cpp
View File

@ -5873,7 +5873,14 @@ DisplayServerWindows::DisplayServerWindows(const String &p_rendering_driver, Win
#if defined(RD_ENABLED) #if defined(RD_ENABLED)
if (rendering_context) { if (rendering_context) {
rendering_device = memnew(RenderingDevice); rendering_device = memnew(RenderingDevice);
rendering_device->initialize(rendering_context, MAIN_WINDOW_ID); if (rendering_device->initialize(rendering_context, MAIN_WINDOW_ID) != OK) {
memdelete(rendering_device);
rendering_device = nullptr;
memdelete(rendering_context);
rendering_context = nullptr;
r_error = ERR_UNAVAILABLE;
return;
}
rendering_device->screen_create(MAIN_WINDOW_ID); rendering_device->screen_create(MAIN_WINDOW_ID);
RendererCompositorRD::make_current(); RendererCompositorRD::make_current();

2
servers/rendering/rendering_device.cpp
View File

@ -5507,7 +5507,7 @@ Error RenderingDevice::initialize(RenderingContextDriver *p_context, DisplayServ
for (uint32_t i = 0; i < frames.size(); i++) { for (uint32_t i = 0; i < frames.size(); i++) {
// Staging was never used, create a block. // Staging was never used, create a block.
err = _insert_staging_block(); err = _insert_staging_block();
ERR_CONTINUE(err != OK); ERR_FAIL_COND_V(err, FAILED);
} }
draw_list = nullptr; draw_list = nullptr;