godotengine/godot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Batching - prevent reordering items over a copybackbuffer

Browse Source 
Reordering an item from after a copybackbuffer to before would result in the wrong thing being rendered into the backbuffer.

This PR puts in a check to prevent reordering over such a boundary.
This commit is contained in:
lawnjelly 2021-02-09 09:03:50 +00:00
parent 4211cb3dc7
commit 35ed654911
1 changed files with 5 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
drivers/gles_common/rasterizer_canvas_batcher.h
View File

@ -2716,6 +2716,11 @@ PREAMBLE(bool)::sort_items_from(int p_start) {
return false; return false;
} }
// disallow sorting over copy back buffer
if (second.item->copy_back_buffer) {
return false;
}
// which neighbour to test // which neighbour to test
int test_last = 2 + bdata.settings_item_reordering_lookahead; int test_last = 2 + bdata.settings_item_reordering_lookahead;
for (int test = 2; test < test_last; test++) { for (int test = 2; test < test_last; test++) {