Avoid modifying csproj globbing includes on remove

Check if the found globbing include already matches the given path on
removing scripts to avoid modifying users' csproj files.

(cherry picked from commit 3086d7c035)
This commit is contained in:
Raul Santos 2022-03-25 16:45:25 +01:00 committed by Rémi Verschelde
parent a7ccdfcc53
commit 3a16557642
1 changed files with 16 additions and 2 deletions

View File

@ -108,8 +108,22 @@ namespace GodotTools.ProjectEditor
var normalizedInclude = include.NormalizePath();
if (root.RemoveItemChecked(itemType, normalizedInclude))
root.Save();
var item = root.FindItemOrNullAbs(itemType, normalizedInclude);
// Couldn't find an existing item that matches to remove
if (item == null)
return;
var glob = MSBuildGlob.Parse(item.Include);
// If the item include uses globbing don't remove it
if (!string.IsNullOrEmpty(glob.WildcardDirectoryPart) || glob.FilenamePart.Contains("*"))
{
return;
}
item.Parent.RemoveChild(item);
root.Save();
}
public static void RenameItemsToNewFolderInProjectChecked(string projectPath, string itemType, string oldFolder, string newFolder)