godotengine
/
godot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix url parsing with port numbers 

String.get_slice_count is always at least 1 or 2 for bases with a port number.
Before this change the following URL would return ERR_INVALID_PARAMETER ```ws://127.0.0.1:8000/test```
This commit is contained in:
Philip Whitfield 2021-06-11 10:09:05 +02:00 committed by GitHub
parent 7e1a6befda
commit 3d9f29910c
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
core/string/ustring.cpp
View File

@ -275,7 +275,7 @@ Error String::parse_url(String &r_scheme, String &r_host, int &r_port, String &r
base = base.substr(pos + 1, base.length() - pos - 1); base = base.substr(pos + 1, base.length() - pos - 1);
} else { } else {
// Anything else // Anything else
if (base.get_slice_count(":") > 1) { if (base.get_slice_count(":") > 2) {
return ERR_INVALID_PARAMETER; return ERR_INVALID_PARAMETER;
} }
pos = base.rfind(":"); pos = base.rfind(":");