godotengine
/
godot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix separating axes for 3D cylinder-face collisions 

When checking for lateral surfaces of a cylinder against the points on a
face, the axis projection does not remove the cylinder position. This
results in the axis pointing to the wrong direction and reports
collisions when there shouldn't be.
This commit is contained in:
Markus Mikonsaari 2024-03-28 00:42:01 +02:00
parent 7c6e85de0d
commit 3f69af9e64
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
servers/physics_3d/godot_collision_solver_3d_sat.cpp
View File

@ -1962,7 +1962,7 @@ static void _collision_cylinder_face(const GodotShape3D *p_a, const Transform3D
// Points of B, cylinder lateral surface. // Points of B, cylinder lateral surface.
for (int i = 0; i < 3; i++) { for (int i = 0; i < 3; i++) {
const Vector3 &point = vertex[i]; const Vector3 point = vertex[i] - p_transform_a.origin;
Vector3 axis = Plane(cyl_axis).project(point).normalized(); Vector3 axis = Plane(cyl_axis).project(point).normalized();
if (axis.dot(normal) < 0.0) { if (axis.dot(normal) < 0.0) {
axis *= -1.0; axis *= -1.0;