From 3fd23da5ee2e69e1aca663b52ecf1f3d61188a64 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?R=C3=A9mi=20Verschelde?= Date: Sun, 19 Nov 2017 21:26:05 +0100 Subject: [PATCH] Rename the version's "revision" to "build" That "revision" was inherited from SVN days but had been since then used to give information about the build: "custom_build", "official", "". It can now be overridden with the BUILD_NAME environment variable. --- core/engine.cpp | 4 ++-- core/version.h | 4 ++-- doc/classes/Engine.xml | 4 ++-- methods.py | 10 +++++----- platform/windows/godot_res.rc | 2 +- 5 files changed, 12 insertions(+), 12 deletions(-) diff --git a/core/engine.cpp b/core/engine.cpp index 9a3c6248a80..53c7a73b43b 100644 --- a/core/engine.cpp +++ b/core/engine.cpp @@ -85,7 +85,7 @@ Dictionary Engine::get_version_info() const { dict["patch"] = 0; #endif dict["status"] = VERSION_STATUS; - dict["revision"] = VERSION_REVISION; + dict["build"] = VERSION_BUILD; dict["year"] = VERSION_YEAR; String hash = VERSION_HASH; @@ -94,7 +94,7 @@ Dictionary Engine::get_version_info() const { String stringver = String(dict["major"]) + "." + String(dict["minor"]); if ((int)dict["patch"] != 0) stringver += "." + String(dict["patch"]); - stringver += "-" + String(dict["status"]) + " (" + String(dict["revision"]) + ")"; + stringver += "-" + String(dict["status"]) + " (" + String(dict["build"]) + ")"; dict["string"] = stringver; return dict; diff --git a/core/version.h b/core/version.h index 01c251c1130..b217d82c5d8 100644 --- a/core/version.h +++ b/core/version.h @@ -30,8 +30,8 @@ #include "version_generated.gen.h" #ifdef VERSION_PATCH -#define VERSION_MKSTRING "" _MKSTR(VERSION_MAJOR) "." _MKSTR(VERSION_MINOR) "." _MKSTR(VERSION_PATCH) "." VERSION_STATUS "." VERSION_REVISION VERSION_MODULE_CONFIG +#define VERSION_MKSTRING "" _MKSTR(VERSION_MAJOR) "." _MKSTR(VERSION_MINOR) "." _MKSTR(VERSION_PATCH) "." VERSION_STATUS "." VERSION_BUILD VERSION_MODULE_CONFIG #else -#define VERSION_MKSTRING "" _MKSTR(VERSION_MAJOR) "." _MKSTR(VERSION_MINOR) "." VERSION_STATUS "." VERSION_REVISION VERSION_MODULE_CONFIG +#define VERSION_MKSTRING "" _MKSTR(VERSION_MAJOR) "." _MKSTR(VERSION_MINOR) "." VERSION_STATUS "." VERSION_BUILD VERSION_MODULE_CONFIG #endif // VERSION_PATCH #define VERSION_FULL_NAME "" VERSION_NAME " v" VERSION_MKSTRING diff --git a/doc/classes/Engine.xml b/doc/classes/Engine.xml index f43bbc2e9db..090e0d79104 100644 --- a/doc/classes/Engine.xml +++ b/doc/classes/Engine.xml @@ -71,8 +71,8 @@ "minor" - Holds the minor version number as a String "patch" - Holds the patch version number as a String "status" - Holds the status (e.g. "beta", "rc1", "rc2", ... "stable") as a String - "revision" - Holds the revision (e.g. "custom-build") as a String - "string" - major + minor + patch + status + revision in a single String + "build" - Holds the build name (e.g. "custom-build") as a String + "string" - major + minor + patch + status + build in a single String diff --git a/methods.py b/methods.py index 511faf7ec15..2be73f02d20 100644 --- a/methods.py +++ b/methods.py @@ -1154,11 +1154,11 @@ def add_module_version_string(self,s): def update_version(module_version_string=""): - rev = "custom_build" + build_name = "custom_build" + if (os.getenv("BUILD_NAME") != None): + build_name = os.getenv("BUILD_NAME") + print("Using custom build name: " + build_name) - if (os.getenv("BUILD_REVISION") != None): - rev = os.getenv("BUILD_REVISION") - print("Using custom revision: " + rev) import version f = open("core/version_generated.gen.h", "w") @@ -1168,8 +1168,8 @@ def update_version(module_version_string=""): f.write("#define VERSION_MINOR " + str(version.minor) + "\n") if (hasattr(version, 'patch')): f.write("#define VERSION_PATCH " + str(version.patch) + "\n") - f.write("#define VERSION_REVISION \"" + str(rev) + "\"\n") f.write("#define VERSION_STATUS \"" + str(version.status) + "\"\n") + f.write("#define VERSION_BUILD \"" + str(build_name) + "\"\n") f.write("#define VERSION_MODULE_CONFIG \"" + str(version.module_config) + module_version_string + "\"\n") import datetime f.write("#define VERSION_YEAR " + str(datetime.datetime.now().year) + "\n") diff --git a/platform/windows/godot_res.rc b/platform/windows/godot_res.rc index 7b745f0f976..c535a749c08 100644 --- a/platform/windows/godot_res.rc +++ b/platform/windows/godot_res.rc @@ -29,7 +29,7 @@ BEGIN VALUE "Licence", "MIT" VALUE "LegalCopyright", "Copyright (c) 2007-" _MKSTR(VERSION_YEAR) " Juan Linietsky, Ariel Manzur" VALUE "Info", "https://godotengine.org" - VALUE "ProductVersion", _MKSTR(VERSION_MAJOR) "." _MKSTR(VERSION_MINOR) PATCH_STRING "." VERSION_REVISION + VALUE "ProductVersion", _MKSTR(VERSION_MAJOR) "." _MKSTR(VERSION_MINOR) PATCH_STRING "." VERSION_BUILD END END BLOCK "VarFileInfo"