godotengine/godot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix joint RID not being passed to _set in PhysicalBone

Browse Source 
Also remove default RID() argument from JointData._set()
This commit is contained in:
David Hoppenbrouwers 2020-12-20 18:39:18 +01:00
parent 5332d212f9
commit 41e00b6787
No known key found for this signature in database
GPG Key ID: D5067409B69028FD
2 changed files with 7 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
scene/3d/physics_body_3d.cpp
View File

@ -1971,7 +1971,7 @@ bool PhysicalBone3D::_set(const StringName &p_name, const Variant &p_value) {
} }
if (joint_data) { if (joint_data) {
if (joint_data->_set(p_name, p_value)) { if (joint_data->_set(p_name, p_value, joint)) {
#ifdef TOOLS_ENABLED #ifdef TOOLS_ENABLED
if (get_gizmo().is_valid()) { if (get_gizmo().is_valid()) {
get_gizmo()->redraw(); get_gizmo()->redraw();

12
scene/3d/physics_body_3d.h
View File

@ -370,7 +370,7 @@ public:
virtual JointType get_joint_type() { return JOINT_TYPE_NONE; } virtual JointType get_joint_type() { return JOINT_TYPE_NONE; }
/// "j" is used to set the parameter inside the PhysicsServer3D /// "j" is used to set the parameter inside the PhysicsServer3D
virtual bool _set(const StringName &p_name, const Variant &p_value, RID j = RID()); virtual bool _set(const StringName &p_name, const Variant &p_value, RID j);
virtual bool _get(const StringName &p_name, Variant &r_ret) const; virtual bool _get(const StringName &p_name, Variant &r_ret) const;
virtual void _get_property_list(List<PropertyInfo> *p_list) const; virtual void _get_property_list(List<PropertyInfo> *p_list) const;
@ -380,7 +380,7 @@ public:
struct PinJointData : public JointData { struct PinJointData : public JointData {
virtual JointType get_joint_type() { return JOINT_TYPE_PIN; } virtual JointType get_joint_type() { return JOINT_TYPE_PIN; }
virtual bool _set(const StringName &p_name, const Variant &p_value, RID j = RID()); virtual bool _set(const StringName &p_name, const Variant &p_value, RID j);
virtual bool _get(const StringName &p_name, Variant &r_ret) const; virtual bool _get(const StringName &p_name, Variant &r_ret) const;
virtual void _get_property_list(List<PropertyInfo> *p_list) const; virtual void _get_property_list(List<PropertyInfo> *p_list) const;
@ -394,7 +394,7 @@ public:
struct ConeJointData : public JointData { struct ConeJointData : public JointData {
virtual JointType get_joint_type() { return JOINT_TYPE_CONE; } virtual JointType get_joint_type() { return JOINT_TYPE_CONE; }
virtual bool _set(const StringName &p_name, const Variant &p_value, RID j = RID()); virtual bool _set(const StringName &p_name, const Variant &p_value, RID j);
virtual bool _get(const StringName &p_name, Variant &r_ret) const; virtual bool _get(const StringName &p_name, Variant &r_ret) const;
virtual void _get_property_list(List<PropertyInfo> *p_list) const; virtual void _get_property_list(List<PropertyInfo> *p_list) const;
@ -411,7 +411,7 @@ public:
struct HingeJointData : public JointData { struct HingeJointData : public JointData {
virtual JointType get_joint_type() { return JOINT_TYPE_HINGE; } virtual JointType get_joint_type() { return JOINT_TYPE_HINGE; }
virtual bool _set(const StringName &p_name, const Variant &p_value, RID j = RID()); virtual bool _set(const StringName &p_name, const Variant &p_value, RID j);
virtual bool _get(const StringName &p_name, Variant &r_ret) const; virtual bool _get(const StringName &p_name, Variant &r_ret) const;
virtual void _get_property_list(List<PropertyInfo> *p_list) const; virtual void _get_property_list(List<PropertyInfo> *p_list) const;
@ -431,7 +431,7 @@ public:
struct SliderJointData : public JointData { struct SliderJointData : public JointData {
virtual JointType get_joint_type() { return JOINT_TYPE_SLIDER; } virtual JointType get_joint_type() { return JOINT_TYPE_SLIDER; }
virtual bool _set(const StringName &p_name, const Variant &p_value, RID j = RID()); virtual bool _set(const StringName &p_name, const Variant &p_value, RID j);
virtual bool _get(const StringName &p_name, Variant &r_ret) const; virtual bool _get(const StringName &p_name, Variant &r_ret) const;
virtual void _get_property_list(List<PropertyInfo> *p_list) const; virtual void _get_property_list(List<PropertyInfo> *p_list) const;
@ -478,7 +478,7 @@ public:
virtual JointType get_joint_type() { return JOINT_TYPE_6DOF; } virtual JointType get_joint_type() { return JOINT_TYPE_6DOF; }
virtual bool _set(const StringName &p_name, const Variant &p_value, RID j = RID()); virtual bool _set(const StringName &p_name, const Variant &p_value, RID j);
virtual bool _get(const StringName &p_name, Variant &r_ret) const; virtual bool _get(const StringName &p_name, Variant &r_ret) const;
virtual void _get_property_list(List<PropertyInfo> *p_list) const; virtual void _get_property_list(List<PropertyInfo> *p_list) const;