godotengine/godot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

GDScript: Make setter parameter type same as variable type

Browse Source
This commit is contained in:
George Marques 2021-10-12 09:39:23 -03:00
parent b67e68bce3
commit 45f546c1d8
No known key found for this signature in database
GPG Key ID: 046BD46A3201E43D
3 changed files with 13 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
modules/gdscript/gdscript_analyzer.cpp
View File

@ -893,11 +893,13 @@ void GDScriptAnalyzer::resolve_class_body(GDScriptParser::ClassNode *p_class) {
resolve_function_body(member.variable->getter); resolve_function_body(member.variable->getter);
} }
if (member.variable->setter != nullptr) { if (member.variable->setter != nullptr) {
resolve_function_signature(member.variable->setter);
if (member.variable->setter->parameters.size() > 0) { if (member.variable->setter->parameters.size() > 0) {
member.variable->setter->parameters[0]->datatype_specifier = member.variable->datatype_specifier; member.variable->setter->parameters[0]->datatype_specifier = member.variable->datatype_specifier;
member.variable->setter->parameters[0]->set_datatype(member.get_datatype());
} }
resolve_function_signature(member.variable->setter);
resolve_function_body(member.variable->setter); resolve_function_body(member.variable->setter);
} }
} }

8
modules/gdscript/tests/scripts/analyzer/errors/setter_parameter_uses_property_type.gd Normal file
View File

@ -0,0 +1,8 @@
var with_setter := 0:
set(val):
var x: String = val
with_setter = val
func test():
with_setter = 1
print(with_setter)

2
modules/gdscript/tests/scripts/analyzer/errors/setter_parameter_uses_property_type.out Normal file
View File

@ -0,0 +1,2 @@
GDTEST_ANALYZER_ERROR
Value of type "int" cannot be assigned to a variable of type "String".