godotengine/godot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge pull request #81934 from Repiteo/c#-CS1591-disabled-to-suggestion

Browse Source 
C#: CS1591 from `NoWarn` to `suggestion`
This commit is contained in:
Rémi Verschelde 2023-09-20 13:10:12 +02:00
commit 4613bfc9df
No known key found for this signature in database
GPG Key ID: C3336907360768E1
2 changed files with 6 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
modules/mono/glue/GodotSharp/.editorconfig
View File

@ -1,5 +1,5 @@
[**/Generated/**.cs] [**/Generated/**.cs]
# Validate parameter is non-null before using it # CA1062: Validate parameter is non-null before using it
# Useful for generated code, as it disables nullable # Useful for generated code, as it disables nullable
dotnet_diagnostic.CA1062.severity = error dotnet_diagnostic.CA1062.severity = error
# CA1069: Enums should not have duplicate values # CA1069: Enums should not have duplicate values
@ -10,3 +10,8 @@ dotnet_diagnostic.CA1708.severity = none
dotnet_diagnostic.CS1591.severity = none dotnet_diagnostic.CS1591.severity = none
# CS1573: Parameter has no matching param tag in the XML comment # CS1573: Parameter has no matching param tag in the XML comment
dotnet_diagnostic.CS1573.severity = none dotnet_diagnostic.CS1573.severity = none
[GodotSharp/Core/**.cs]
# CS1591: Missing XML comment for publicly visible type or member
# TODO: Temporary change to not pollute the warnings, but we need to document public APIs
dotnet_diagnostic.CS1591.severity = suggestion

3
modules/mono/glue/GodotSharp/GodotSharp/GodotSharp.csproj
View File

@ -11,9 +11,6 @@
<LangVersion>10</LangVersion> <LangVersion>10</LangVersion>
<AnalysisMode>Recommended</AnalysisMode> <AnalysisMode>Recommended</AnalysisMode>
<!-- Disabled temporarily as it pollutes the warnings, but we need to document public APIs. -->
<NoWarn>CS1591</NoWarn>
</PropertyGroup> </PropertyGroup>
<PropertyGroup> <PropertyGroup>
<Description>Godot C# Core API.</Description> <Description>Godot C# Core API.</Description>