godotengine
/
godot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Add node configuration warning for GeometryInstance3D distance

This commit is contained in:
Hugo Locurcio 2021-07-28 19:33:14 +02:00
parent 60eb508fbb
commit 48fc5b2480
No known key found for this signature in database
GPG Key ID: 39E8F8BE30B0A49C
2 changed files with 13 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
scene/3d/visual_instance_3d.cpp
View File

@ -153,6 +153,7 @@ Ref<Material> GeometryInstance3D::get_material_override() const {
void GeometryInstance3D::set_visibility_range_begin(float p_dist) { void GeometryInstance3D::set_visibility_range_begin(float p_dist) {
visibility_range_begin = p_dist; visibility_range_begin = p_dist;
RS::get_singleton()->instance_geometry_set_visibility_range(get_instance(), visibility_range_begin, visibility_range_end, visibility_range_begin_margin, visibility_range_end_margin); RS::get_singleton()->instance_geometry_set_visibility_range(get_instance(), visibility_range_begin, visibility_range_end, visibility_range_begin_margin, visibility_range_end_margin);
update_configuration_warnings();
} }
float GeometryInstance3D::get_visibility_range_begin() const { float GeometryInstance3D::get_visibility_range_begin() const {
@ -162,6 +163,7 @@ float GeometryInstance3D::get_visibility_range_begin() const {
void GeometryInstance3D::set_visibility_range_end(float p_dist) { void GeometryInstance3D::set_visibility_range_end(float p_dist) {
visibility_range_end = p_dist; visibility_range_end = p_dist;
RS::get_singleton()->instance_geometry_set_visibility_range(get_instance(), visibility_range_begin, visibility_range_end, visibility_range_begin_margin, visibility_range_end_margin); RS::get_singleton()->instance_geometry_set_visibility_range(get_instance(), visibility_range_begin, visibility_range_end, visibility_range_begin_margin, visibility_range_end_margin);
update_configuration_warnings();
} }
float GeometryInstance3D::get_visibility_range_end() const { float GeometryInstance3D::get_visibility_range_end() const {
@ -351,6 +353,16 @@ bool GeometryInstance3D::is_ignoring_occlusion_culling() {
return ignore_occlusion_culling; return ignore_occlusion_culling;
} }
TypedArray<String> GeometryInstance3D::get_configuration_warnings() const {
TypedArray<String> warnings = Node::get_configuration_warnings();
if (!Math::is_zero_approx(visibility_range_end) && visibility_range_end <= visibility_range_begin) {
warnings.push_back(TTR("The GeometryInstance3D visibility range's End distance is set to a non-zero value, but is lower than the Begin distance.\nThis means the GeometryInstance3D will never be visible.\nTo resolve this, set the End distance to 0 or to a value greater than the Begin distance."));
}
return warnings;
}
void GeometryInstance3D::_bind_methods() { void GeometryInstance3D::_bind_methods() {
ClassDB::bind_method(D_METHOD("set_material_override", "material"), &GeometryInstance3D::set_material_override); ClassDB::bind_method(D_METHOD("set_material_override", "material"), &GeometryInstance3D::set_material_override);
ClassDB::bind_method(D_METHOD("get_material_override"), &GeometryInstance3D::get_material_override); ClassDB::bind_method(D_METHOD("get_material_override"), &GeometryInstance3D::get_material_override);

1
scene/3d/visual_instance_3d.h
View File

@ -177,6 +177,7 @@ public:
void set_ignore_occlusion_culling(bool p_enabled); void set_ignore_occlusion_culling(bool p_enabled);
bool is_ignoring_occlusion_culling(); bool is_ignoring_occlusion_culling();
TypedArray<String> get_configuration_warnings() const override;
GeometryInstance3D(); GeometryInstance3D();
}; };