godotengine
/
godot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge pull request #31768 from qarmin/fix_memory_leak_in_ResourceFormatSaverBinary 

Fix memory leak in ResourceFormatSaverBinary::save
This commit is contained in:
Rémi Verschelde 2019-08-30 15:02:49 +02:00 committed by GitHub
parent 3db1d40045 b244ab4acc
commit 495a0a97a2
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
core/io/resource_format_binary.cpp
View File

@ -1786,6 +1786,7 @@ Error ResourceFormatSaverBinaryInstance::save(const String &p_path, const RES &p
if (f->get_error() != OK && f->get_error() != ERR_FILE_EOF) { if (f->get_error() != OK && f->get_error() != ERR_FILE_EOF) {
f->close(); f->close();
memdelete(f);
return ERR_CANT_CREATE; return ERR_CANT_CREATE;
} }
@ -1938,10 +1939,12 @@ Error ResourceFormatSaverBinaryInstance::save(const String &p_path, const RES &p
if (f->get_error() != OK && f->get_error() != ERR_FILE_EOF) { if (f->get_error() != OK && f->get_error() != ERR_FILE_EOF) {
f->close(); f->close();
memdelete(f);
return ERR_CANT_CREATE; return ERR_CANT_CREATE;
} }
f->close(); f->close();
memdelete(f);
return OK; return OK;
} }