From 4b8fa3716f384064382fc0c7cb7bb91fde1626e0 Mon Sep 17 00:00:00 2001 From: nova++ <3247833+novaplusplus@users.noreply.github.com> Date: Thu, 10 Mar 2022 20:25:59 -0500 Subject: [PATCH] Fix "p_from_line > p_to_line" errors in text edit Done via making the function more robust to different inputs --- scene/gui/text_edit.cpp | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/scene/gui/text_edit.cpp b/scene/gui/text_edit.cpp index 05fda7128c6..3c80e3f9878 100644 --- a/scene/gui/text_edit.cpp +++ b/scene/gui/text_edit.cpp @@ -4469,7 +4469,11 @@ int TextEdit::get_visible_line_count() const { int TextEdit::get_visible_line_count_in_range(int p_from_line, int p_to_line) const { ERR_FAIL_INDEX_V(p_from_line, text.size(), 0); ERR_FAIL_INDEX_V(p_to_line, text.size(), 0); - ERR_FAIL_COND_V(p_from_line > p_to_line, 0); + + // So we can handle inputs in whatever order + if (p_from_line > p_to_line) { + SWAP(p_from_line, p_to_line); + } /* Returns the total number of (lines + wrapped - hidden). */ if (!_is_hiding_enabled() && get_line_wrapping_mode() == LineWrappingMode::LINE_WRAPPING_NONE) {