godotengine/godot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge pull request #67939 from sambriels/emit-signal-after-target-reached

Browse Source 
[NavigationAgent2D/3D]: target_reached signal is emitted before internal state is updated
This commit is contained in:
Clay John 2022-10-27 12:52:13 -07:00 committed by GitHub
commit 4dc2c8ae6f
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
scene/2d/navigation_agent_2d.cpp
View File

@ -478,8 +478,8 @@ void NavigationAgent2D::_request_repath() {
void NavigationAgent2D::_check_distance_to_target() { void NavigationAgent2D::_check_distance_to_target() {
if (!target_reached) { if (!target_reached) {
if (distance_to_target() < target_desired_distance) { if (distance_to_target() < target_desired_distance) {
emit_signal(SNAME("target_reached"));
target_reached = true; target_reached = true;
emit_signal(SNAME("target_reached"));
} }
} }
} }

2
scene/3d/navigation_agent_3d.cpp
View File

@ -495,8 +495,8 @@ void NavigationAgent3D::_request_repath() {
void NavigationAgent3D::_check_distance_to_target() { void NavigationAgent3D::_check_distance_to_target() {
if (!target_reached) { if (!target_reached) {
if (distance_to_target() < target_desired_distance) { if (distance_to_target() < target_desired_distance) {
emit_signal(SNAME("target_reached"));
target_reached = true; target_reached = true;
emit_signal(SNAME("target_reached"));
} }
} }
} }