godotengine/godot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Make Color Picker, Menu Button, Option Button consider camera position scale for popup position.

Browse Source
This commit is contained in:
menip 2021-08-30 08:42:33 -07:00
parent 4d08a737fb
commit 4f4c9a5f57
3 changed files with 8 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
scene/gui/color_picker.cpp
View File

@ -1308,6 +1308,8 @@ void ColorPickerButton::_modal_closed() {
void ColorPickerButton::pressed() { void ColorPickerButton::pressed() {
_update_picker(); _update_picker();
Size2 size = get_size() * get_viewport()->get_canvas_transform().get_scale();
popup->set_as_minsize(); popup->set_as_minsize();
picker->_update_presets(); picker->_update_presets();
@ -1319,13 +1321,13 @@ void ColorPickerButton::pressed() {
if (i > 1) { if (i > 1) {
cp_rect.position.y = get_screen_position().y - cp_rect.size.y; cp_rect.position.y = get_screen_position().y - cp_rect.size.y;
} else { } else {
cp_rect.position.y = get_screen_position().y + get_size().height; cp_rect.position.y = get_screen_position().y + size.height;
} }
if (i & 1) { if (i & 1) {
cp_rect.position.x = get_screen_position().x; cp_rect.position.x = get_screen_position().x;
} else { } else {
cp_rect.position.x = get_screen_position().x - MAX(0, (cp_rect.size.x - get_size().x)); cp_rect.position.x = get_screen_position().x - MAX(0, (cp_rect.size.x - size.x));
} }
if (usable_rect.encloses(cp_rect)) { if (usable_rect.encloses(cp_rect)) {

6
scene/gui/menu_button.cpp
View File

@ -87,15 +87,15 @@ void MenuButton::_popup_visibility_changed(bool p_visible) {
void MenuButton::pressed() { void MenuButton::pressed() {
emit_signal(SNAME("about_to_popup")); emit_signal(SNAME("about_to_popup"));
Size2 size = get_size(); Size2 size = get_size() * get_viewport()->get_canvas_transform().get_scale();
Point2 gp = get_screen_position(); Point2 gp = get_screen_position();
gp.y += get_size().y; gp.y += size.y;
popup->set_position(gp); popup->set_position(gp);
popup->set_size(Size2(size.width, 0)); popup->set_size(Size2(size.width, 0));
popup->set_parent_rect(Rect2(Point2(gp - popup->get_position()), get_size())); popup->set_parent_rect(Rect2(Point2(gp - popup->get_position()), size));
popup->take_mouse_focus(); popup->take_mouse_focus();
popup->popup(); popup->popup();
} }

2
scene/gui/option_button.cpp
View File

@ -115,7 +115,7 @@ void OptionButton::_selected(int p_which) {
} }
void OptionButton::pressed() { void OptionButton::pressed() {
Size2 size = get_size(); Size2 size = get_size() * get_viewport()->get_canvas_transform().get_scale();
popup->set_position(get_screen_position() + Size2(0, size.height * get_global_transform().get_scale().y)); popup->set_position(get_screen_position() + Size2(0, size.height * get_global_transform().get_scale().y));
popup->set_size(Size2(size.width, 0)); popup->set_size(Size2(size.width, 0));
popup->popup(); popup->popup();