godotengine/godot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix DirAccessWindows::make_dir() choking on ".."

Browse Source 
`CreateDirectoryW()` chokes on absolute paths that contain `..`
example: "C:\\workspace\\..\\games\\assets"
Simplifying the path before creating the dir fixes this.

(cherry picked from commit 0d3d5ac769)
This commit is contained in:
nikitalita 2022-09-26 12:24:02 -07:00 committed by Haoyu Qiu
parent 4bf7695671
commit 5089429073
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/windows/dir_access_windows.cpp
View File

@ -154,7 +154,7 @@ Error DirAccessWindows::make_dir(String p_dir) {
if (p_dir.is_rel_path()) if (p_dir.is_rel_path())
p_dir = current_dir.plus_file(p_dir); p_dir = current_dir.plus_file(p_dir);
p_dir = p_dir.replace("/", "\\"); p_dir = p_dir.simplify_path().replace("/", "\\");
bool success; bool success;
int err; int err;