godotengine
/
godot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Tests: Don't assume translation map ordering 

This lead to randomly failing the test as the insertion order is not
preserved by Map.

Follow-up to #48778.

Co-authored-by: kleonc <9283098+kleonc@users.noreply.github.com>
This commit is contained in:
Rémi Verschelde 2021-05-17 12:29:24 +02:00
parent 2be9b5dec4
commit 56100c2dd7
No known key found for this signature in database
GPG Key ID: C3336907360768E1
1 changed files with 6 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
tests/test_translation.h
View File

@ -60,8 +60,9 @@ TEST_CASE("[Translation] Messages") {
translation->get_message_list(&messages);
CHECK(translation->get_message_count() == 2);
CHECK(messages.size() == 2);
CHECK(messages[0] == "Hello2");
CHECK(messages[1] == "Hello3");
// Messages are stored in a Map, don't assume ordering.
CHECK(messages.find("Hello2"));
CHECK(messages.find("Hello3"));
}
TEST_CASE("[TranslationPO] Messages with context") {
@ -99,8 +100,9 @@ TEST_CASE("[TranslationPO] Messages with context") {
CHECK(translation->get_message_count() == 4);
// Only the default context is taken into account.
CHECK(messages.size() == 2);
CHECK(messages[0] == "Hello2");
CHECK(messages[1] == "Hello3");
// Messages are stored in a Map, don't assume ordering.
CHECK(messages.find("Hello2"));
CHECK(messages.find("Hello3"));
}
TEST_CASE("[TranslationPO] Plural messages") {