godotengine
/
godot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix issue preventing enabling the remote button for Android 

https://github.com/godotengine/godot/pull/92032 updated the logic to enable / disable the remote debug button, and in doing so added a `can_export` check.

However, no events / notifications are dispatched when the value of the `can_export` check changes, which in turn prevents the logic used to enable / disable the remote debug button from running again.

The fix consists then in removing the `can_export` check, so that the remote debug button shows as `enabled` when a preset is present and is runnable.
This commit is contained in:
Fredia Huya-Kouadio 2024-07-16 00:25:16 -07:00
parent 97b8ad1af0
commit 5b327aee96
3 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
editor/editor_run_native.cpp
View File

@ -58,12 +58,12 @@ void EditorRunNative::_notification(int p_what) {
for (int j = 0; j < EditorExport::get_singleton()->get_export_platform_count(); j++) { for (int j = 0; j < EditorExport::get_singleton()->get_export_platform_count(); j++) {
if (eep->get_name() == EditorExport::get_singleton()->get_export_platform(j)->get_name()) { if (eep->get_name() == EditorExport::get_singleton()->get_export_platform(j)->get_name()) {
platform_idx = j; platform_idx = j;
break;
} }
} }
int dc = MIN(eep->get_options_count(), 9000); int dc = MIN(eep->get_options_count(), 9000);
bool needs_templates;
String error; String error;
if (dc > 0 && preset->is_runnable() && eep->can_export(preset, error, needs_templates)) { if (dc > 0 && preset->is_runnable()) {
popup->add_icon_item(eep->get_run_icon(), eep->get_name(), -1); popup->add_icon_item(eep->get_run_icon(), eep->get_name(), -1);
popup->set_item_disabled(-1, true); popup->set_item_disabled(-1, true);
for (int j = 0; j < dc; j++) { for (int j = 0; j < dc; j++) {

1
platform/android/export/export_plugin.cpp
View File

@ -441,6 +441,7 @@ void EditorExportPlatformAndroid::_update_preset_status() {
} else { } else {
has_runnable_preset.clear(); has_runnable_preset.clear();
} }
devices_changed.set();
} }
#endif #endif

1
platform/ios/export/export_plugin.cpp
View File

@ -2971,6 +2971,7 @@ void EditorExportPlatformIOS::_update_preset_status() {
} else { } else {
has_runnable_preset.clear(); has_runnable_preset.clear();
} }
devices_changed.set();
} }
#endif #endif