From 69f36cea8c5e706125ab419f8e845d3aa657f373 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?R=C3=A9mi=20Verschelde?= Date: Mon, 4 May 2020 16:09:19 +0200 Subject: [PATCH] Revert "Emit signal when animation ends by seek" This reverts commit bf1cc116e15ec155c1dfff06bd02d2f1dfc21ee0. This needs more discussion to avoid breaking some users' expectations. See #38086 for arguments. --- scene/animation/animation_player.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/scene/animation/animation_player.cpp b/scene/animation/animation_player.cpp index 9ef6b9864a8..8228cf67bdb 100644 --- a/scene/animation/animation_player.cpp +++ b/scene/animation/animation_player.cpp @@ -950,13 +950,13 @@ void AnimationPlayer::_animation_process(float p_delta) { play(queued.front()->get()); String new_name = playback.assigned; queued.pop_front(); - if (end_notify || playback.seeked) + if (end_notify) emit_signal(SceneStringNames::get_singleton()->animation_changed, old, new_name); } else { //stop(); playing = false; _set_process(false); - if (end_notify || playback.seeked) + if (end_notify) emit_signal(SceneStringNames::get_singleton()->animation_finished, playback.assigned); } end_reached = false;