From 6c0f3f8d0ca9e30951f0e6e643af07ca7ed695a9 Mon Sep 17 00:00:00 2001 From: marynate Date: Tue, 6 May 2014 17:43:14 +0800 Subject: [PATCH] Implement Shift+F1 as contextual help hotkey for script editor; There's one bug that when jump to help tab first time, the scroll position is wrong. --- tools/editor/plugins/script_editor_plugin.cpp | 17 ++++++++--------- tools/editor/plugins/script_editor_plugin.h | 3 ++- 2 files changed, 10 insertions(+), 10 deletions(-) diff --git a/tools/editor/plugins/script_editor_plugin.cpp b/tools/editor/plugins/script_editor_plugin.cpp index 2d2e02f5c4a..83cf753692d 100644 --- a/tools/editor/plugins/script_editor_plugin.cpp +++ b/tools/editor/plugins/script_editor_plugin.cpp @@ -394,7 +394,6 @@ ScriptTextEditor::ScriptTextEditor() { /*** SCRIPT EDITOR ******/ - String ScriptEditor::_get_debug_tooltip(const String&p_text,Node *_ste) { ScriptTextEditor *ste=_ste->cast_to(); @@ -752,10 +751,12 @@ void ScriptEditor::_menu_option(int p_option) { debugger->show(); } } break; - case HELP_SELECTED: { - String selected = current->get_text_edit()->get_selection_text(); - editor->call("_editor_select", 3); - editor->emit_signal("request_help", selected); + case HELP_CONTEXTUAL: { + String text = current->get_text_edit()->get_selection_text(); + if (text == "") + text = current->get_text_edit()->get_word_under_cursor(); + if (text != "") + editor->emit_signal("request_help", text); } break; case WINDOW_CLOSE: { @@ -1056,9 +1057,6 @@ void ScriptEditor::_bind_methods() { ObjectTypeDB::bind_method("_show_debugger",&ScriptEditor::_show_debugger); ObjectTypeDB::bind_method("_get_debug_tooltip",&ScriptEditor::_get_debug_tooltip); - - - } @@ -1370,7 +1368,7 @@ ScriptEditor::ScriptEditor(EditorNode *p_editor) { help_menu = memnew( MenuButton ); menu_hb->add_child(help_menu); help_menu->set_text("Help"); - help_menu->get_popup()->add_item("Selected", HELP_SELECTED, KEY_MASK_CTRL|KEY_MASK_SHIFT|KEY_D); + help_menu->get_popup()->add_item("Contextual", HELP_CONTEXTUAL, KEY_MASK_SHIFT|KEY_F1); help_menu->get_popup()->connect("item_pressed", this,"_menu_option"); tab_container->connect("tab_changed", this,"_tab_changed"); @@ -1425,6 +1423,7 @@ ScriptEditor::ScriptEditor(EditorNode *p_editor) { v_split->add_child(debugger); debugger->connect("breaked",this,"_breaked"); // debugger_gui->hide(); + } diff --git a/tools/editor/plugins/script_editor_plugin.h b/tools/editor/plugins/script_editor_plugin.h index af1fe1c6c34..97f1702f8f3 100644 --- a/tools/editor/plugins/script_editor_plugin.h +++ b/tools/editor/plugins/script_editor_plugin.h @@ -133,7 +133,7 @@ class ScriptEditor : public VBoxContainer { DEBUG_BREAK, DEBUG_CONTINUE, DEBUG_SHOW, - HELP_SELECTED, + HELP_CONTEXTUAL, WINDOW_CLOSE, WINDOW_MOVE_LEFT, WINDOW_MOVE_RIGHT, @@ -187,6 +187,7 @@ class ScriptEditor : public VBoxContainer { void _breaked(bool p_breaked,bool p_can_debug); void _show_debugger(bool p_show); void _update_window_menu(); + static ScriptEditor *script_editor; protected: void _notification(int p_what);