godotengine
/
godot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Editor Feature Profile: Only rebuild selected TreeItem and all children when a property is edited

This commit is contained in:
Marius Hanl 2024-05-20 02:12:57 +02:00
parent daa81bbb7d
commit 7008111a3f
2 changed files with 17 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
editor/editor_feature_profile.cpp
View File

@ -497,8 +497,8 @@ void EditorFeatureProfileManager::_hide_requested() {
_cancel_pressed(); // From AcceptDialog. _cancel_pressed(); // From AcceptDialog.
} }
void EditorFeatureProfileManager::_fill_classes_from(TreeItem *p_parent, const String &p_class, const String &p_selected) { void EditorFeatureProfileManager::_fill_classes_from(TreeItem *p_parent, const String &p_class, const String &p_selected, int p_class_insert_index) {
TreeItem *class_item = class_list->create_item(p_parent); TreeItem *class_item = class_list->create_item(p_parent, p_class_insert_index);
class_item->set_cell_mode(0, TreeItem::CELL_MODE_CHECK); class_item->set_cell_mode(0, TreeItem::CELL_MODE_CHECK);
class_item->set_icon(0, EditorNode::get_singleton()->get_class_icon(p_class)); class_item->set_icon(0, EditorNode::get_singleton()->get_class_icon(p_class));
String text = p_class; String text = p_class;
@ -647,7 +647,7 @@ void EditorFeatureProfileManager::_class_list_item_edited() {
String class_selected = md; String class_selected = md;
edited->set_disable_class(class_selected, !checked); edited->set_disable_class(class_selected, !checked);
_save_and_update(); _save_and_update();
_update_selected_profile(); _update_profile_tree_from(item);
} else if (md.get_type() == Variant::INT) { } else if (md.get_type() == Variant::INT) {
int feature_selected = md; int feature_selected = md;
edited->set_disable_feature(EditorFeatureProfile::Feature(feature_selected), !checked); edited->set_disable_feature(EditorFeatureProfile::Feature(feature_selected), !checked);
@ -703,19 +703,29 @@ void EditorFeatureProfileManager::_property_item_edited() {
String property_selected = md; String property_selected = md;
edited->set_disable_class_property(class_name, property_selected, !checked); edited->set_disable_class_property(class_name, property_selected, !checked);
_save_and_update(); _save_and_update();
_update_selected_profile(); _update_profile_tree_from(class_list->get_selected());
} else if (md.get_type() == Variant::INT) { } else if (md.get_type() == Variant::INT) {
int feature_selected = md; int feature_selected = md;
switch (feature_selected) { switch (feature_selected) {
case CLASS_OPTION_DISABLE_EDITOR: { case CLASS_OPTION_DISABLE_EDITOR: {
edited->set_disable_class_editor(class_name, !checked); edited->set_disable_class_editor(class_name, !checked);
_save_and_update(); _save_and_update();
_update_selected_profile(); _update_profile_tree_from(class_list->get_selected());
} break; } break;
} }
} }
} }
void EditorFeatureProfileManager::_update_profile_tree_from(TreeItem *p_edited) {
String edited_class = p_edited->get_metadata(0);
TreeItem *edited_parent = p_edited->get_parent();
int class_insert_index = p_edited->get_index();
p_edited->get_parent()->remove_child(p_edited);
_fill_classes_from(edited_parent, edited_class, edited_class, class_insert_index);
}
void EditorFeatureProfileManager::_update_selected_profile() { void EditorFeatureProfileManager::_update_selected_profile() {
String class_selected; String class_selected;
int feature_selected = -1; int feature_selected = -1;

3
editor/editor_feature_profile.h
View File

@ -147,7 +147,8 @@ class EditorFeatureProfileManager : public AcceptDialog {
String current_profile; String current_profile;
void _update_profile_list(const String &p_select_profile = String()); void _update_profile_list(const String &p_select_profile = String());
void _update_selected_profile(); void _update_selected_profile();
void _fill_classes_from(TreeItem *p_parent, const String &p_class, const String &p_selected); void _update_profile_tree_from(TreeItem *p_edited);
void _fill_classes_from(TreeItem *p_parent, const String &p_class, const String &p_selected, int p_class_insert_index = -1);
Ref<EditorFeatureProfile> current; Ref<EditorFeatureProfile> current;
Ref<EditorFeatureProfile> edited; Ref<EditorFeatureProfile> edited;