godotengine
/
godot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge pull request #53811 from V-Sekai/dev-yes 

Fix specific warnings issues by Clang
This commit is contained in:
Rémi Verschelde 2021-10-15 00:38:08 +02:00 committed by GitHub
parent 8aef0e3ad9 8f0c056431
commit 78ddae8512
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
6 changed files with 3 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
core/string/optimized_translation.cpp
View File

@ -64,7 +64,6 @@ void OptimizedTranslation::generate(const Ref<Translation> &p_from) {
int idx = 0; int idx = 0;
int total_compression_size = 0; int total_compression_size = 0;
int total_string_size = 0;
for (const StringName &E : keys) { for (const StringName &E : keys) {
//hash string //hash string
@ -102,7 +101,6 @@ void OptimizedTranslation::generate(const Ref<Translation> &p_from) {
compressed.write[idx] = ps; compressed.write[idx] = ps;
total_compression_size += ps.compressed.size(); total_compression_size += ps.compressed.size();
total_string_size += src_s.size();
idx++; idx++;
} }
@ -147,15 +145,12 @@ void OptimizedTranslation::generate(const Ref<Translation> &p_from) {
uint32_t *btw = (uint32_t *)&btwb[0]; uint32_t *btw = (uint32_t *)&btwb[0];
int btindex = 0; int btindex = 0;
int collisions = 0;
for (int i = 0; i < size; i++) { for (int i = 0; i < size; i++) {
const Map<uint32_t, int> &t = table[i]; const Map<uint32_t, int> &t = table[i];
if (t.size() == 0) { if (t.size() == 0) {
htw[i] = 0xFFFFFFFF; //nothing htw[i] = 0xFFFFFFFF; //nothing
continue; continue;
} else if (t.size() > 1) {
collisions += t.size() - 1;
} }
htw[i] = btindex; htw[i] = btindex;

4
editor/debugger/editor_visual_profiler.cpp
View File

@ -370,8 +370,8 @@ void EditorVisualProfiler::_update_frame(bool p_focus_selected) {
float total_gpu = E->get_metadata(2); float total_gpu = E->get_metadata(2);
total_cpu += cpu_time; total_cpu += cpu_time;
total_gpu += gpu_time; total_gpu += gpu_time;
E->set_metadata(1, cpu_time); E->set_metadata(1, total_cpu);
E->set_metadata(2, gpu_time); E->set_metadata(2, total_gpu);
} }
category->set_icon(0, track_icon); category->set_icon(0, track_icon);

3
modules/fbx/data/fbx_mesh_data.cpp
View File

@ -357,7 +357,6 @@ ImporterMeshInstance3D *FBXMeshData::create_fbx_mesh(const ImportState &state, c
mesh->set_blend_shape_mode(Mesh::BLEND_SHAPE_MODE_NORMALIZED); mesh->set_blend_shape_mode(Mesh::BLEND_SHAPE_MODE_NORMALIZED);
// Add surfaces. // Add surfaces.
int in_mesh_surface_id = 0;
for (const SurfaceId *surface_id = surfaces.next(nullptr); surface_id != nullptr; surface_id = surfaces.next(surface_id)) { for (const SurfaceId *surface_id = surfaces.next(nullptr); surface_id != nullptr; surface_id = surfaces.next(surface_id)) {
SurfaceData *surface = surfaces.getptr(*surface_id); SurfaceData *surface = surfaces.getptr(*surface_id);
@ -377,8 +376,6 @@ ImporterMeshInstance3D *FBXMeshData::create_fbx_mesh(const ImportState &state, c
} else { } else {
mesh->add_surface(Mesh::PRIMITIVE_TRIANGLES, mesh_array, blend_shapes); mesh->add_surface(Mesh::PRIMITIVE_TRIANGLES, mesh_array, blend_shapes);
} }
in_mesh_surface_id += 1;
} }
ImporterMeshInstance3D *godot_mesh = memnew(ImporterMeshInstance3D); ImporterMeshInstance3D *godot_mesh = memnew(ImporterMeshInstance3D);

2
platform/iphone/export/export_plugin.cpp
View File

@ -1427,7 +1427,6 @@ Error EditorExportPlatformIOS::export_project(const Ref<EditorExportPreset> &p_p
} }
bool found_library = false; bool found_library = false;
int total_size = 0;
const String project_file = "godot_ios.xcodeproj/project.pbxproj"; const String project_file = "godot_ios.xcodeproj/project.pbxproj";
Set<String> files_to_parse; Set<String> files_to_parse;
@ -1523,7 +1522,6 @@ Error EditorExportPlatformIOS::export_project(const Ref<EditorExportPreset> &p_p
file = file.replace("godot_ios", binary_name); file = file.replace("godot_ios", binary_name);
print_line("ADDING: " + file + " size: " + itos(data.size())); print_line("ADDING: " + file + " size: " + itos(data.size()));
total_size += data.size();
/* write it into our folder structure */ /* write it into our folder structure */
file = dest_dir + file; file = dest_dir + file;

2
platform/osx/export/export_plugin.cpp
View File

@ -561,7 +561,6 @@ Error EditorExportPlatformOSX::export_project(const Ref<EditorExportPreset> &p_p
// Now process our template. // Now process our template.
bool found_binary = false; bool found_binary = false;
int total_size = 0;
Vector<String> dylibs_found; Vector<String> dylibs_found;
while (ret == UNZ_OK && err == OK) { while (ret == UNZ_OK && err == OK) {
@ -649,7 +648,6 @@ Error EditorExportPlatformOSX::export_project(const Ref<EditorExportPreset> &p_p
} }
print_line("ADDING: " + file + " size: " + itos(data.size())); print_line("ADDING: " + file + " size: " + itos(data.size()));
total_size += data.size();
// Write it into our application bundle. // Write it into our application bundle.
file = tmp_app_path_name.plus_file(file); file = tmp_app_path_name.plus_file(file);

2
platform/windows/display_server_windows.h
View File

@ -462,7 +462,7 @@ public:
virtual bool screen_is_touchscreen(int p_screen = SCREEN_OF_MAIN_WINDOW) const override; virtual bool screen_is_touchscreen(int p_screen = SCREEN_OF_MAIN_WINDOW) const override;
virtual void screen_set_orientation(ScreenOrientation p_orientation, int p_screen = SCREEN_OF_MAIN_WINDOW) override; virtual void screen_set_orientation(ScreenOrientation p_orientation, int p_screen = SCREEN_OF_MAIN_WINDOW) override;
ScreenOrientation screen_get_orientation(int p_screen = SCREEN_OF_MAIN_WINDOW) const; virtual ScreenOrientation screen_get_orientation(int p_screen = SCREEN_OF_MAIN_WINDOW) const override;
virtual void screen_set_keep_on(bool p_enable) override; //disable screensaver virtual void screen_set_keep_on(bool p_enable) override; //disable screensaver
virtual bool screen_is_kept_on() const override; virtual bool screen_is_kept_on() const override;