godotengine
/
godot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Do not call _update_actions when only changing deadzone 

Because changing the deadzone with a click happens during
_propagate_mouse_event the tree is always blocked leading to a crash. We
don't actually need to update actions here anyway.

This fixes #20184
This commit is contained in:
Hein-Pieter van Braam 2018-08-05 22:22:16 +02:00
parent d5d83b754d
commit 7db66fea39
1 changed files with 0 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
editor/project_settings_editor.cpp
View File

@ -213,10 +213,8 @@ void ProjectSettingsEditor::_action_edited() {
undo_redo->create_action(TTR("Change Action deadzone")); undo_redo->create_action(TTR("Change Action deadzone"));
undo_redo->add_do_method(ProjectSettings::get_singleton(), "set", name, new_action); undo_redo->add_do_method(ProjectSettings::get_singleton(), "set", name, new_action);
undo_redo->add_do_method(this, "_update_actions");
undo_redo->add_do_method(this, "_settings_changed"); undo_redo->add_do_method(this, "_settings_changed");
undo_redo->add_undo_method(ProjectSettings::get_singleton(), "set", name, old_action); undo_redo->add_undo_method(ProjectSettings::get_singleton(), "set", name, old_action);
undo_redo->add_undo_method(this, "_update_actions");
undo_redo->add_undo_method(this, "_settings_changed"); undo_redo->add_undo_method(this, "_settings_changed");
undo_redo->commit_action(); undo_redo->commit_action();
} }