godotengine/godot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Portals - Fix RoomManager PVS enum

Browse Source 
The PVS mode enum had been declared using scope operator, which does not seem to work correctly from GDScript with the BIND_ENUM_CONSTANT macro.

This PR removes the scope operator in the declaration.
This commit is contained in:
lawnjelly 2021-08-28 07:21:47 +01:00
parent 17e61fa0af
commit 7ea35da462
2 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
doc/classes/RoomManager.xml
View File

@ -94,13 +94,13 @@
</member>
</members>
<constants>
<constant name="RoomManager::PVS_MODE_DISABLED" value="0" enum="PVSMode">
<constant name="PVS_MODE_DISABLED" value="0" enum="PVSMode">
Use only [Portal]s at runtime to determine visibility. PVS will not be generated at [Room]s conversion, and gameplay notifications cannot be used.
</constant>
<constant name="RoomManager::PVS_MODE_PARTIAL" value="1" enum="PVSMode">
<constant name="PVS_MODE_PARTIAL" value="1" enum="PVSMode">
Use a combination of PVS and [Portal]s to determine visibility (this is usually fastest and most accurate).
</constant>
<constant name="RoomManager::PVS_MODE_FULL" value="2" enum="PVSMode">
<constant name="PVS_MODE_FULL" value="2" enum="PVSMode">
Use only the PVS (potentially visible set) of [Room]s to determine visibility.
</constant>
</constants>

6
scene/3d/room_manager.cpp
View File

@ -256,9 +256,9 @@ void RoomManager::_notification(int p_what) {
}
void RoomManager::_bind_methods() {
BIND_ENUM_CONSTANT(RoomManager::PVS_MODE_DISABLED);
BIND_ENUM_CONSTANT(RoomManager::PVS_MODE_PARTIAL);
BIND_ENUM_CONSTANT(RoomManager::PVS_MODE_FULL);
BIND_ENUM_CONSTANT(PVS_MODE_DISABLED);
BIND_ENUM_CONSTANT(PVS_MODE_PARTIAL);
BIND_ENUM_CONSTANT(PVS_MODE_FULL);
// main functions
ClassDB::bind_method(D_METHOD("rooms_convert"), &RoomManager::rooms_convert);