godotengine
/
godot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Improve Timer error messages 

- Mention the node path (or node name if not in tree).
- Mention the provided invalid wait time.
This commit is contained in:
Hugo Locurcio 2024-08-15 19:01:37 +02:00
parent ee363af0ed
commit 7eacc457ee
No known key found for this signature in database
GPG Key ID: 39E8F8BE30B0A49C
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
scene/main/timer.cpp
View File

@ -80,7 +80,7 @@ void Timer::_notification(int p_what) {
}
void Timer::set_wait_time(double p_time) {
ERR_FAIL_COND_MSG(p_time <= 0, "Time should be greater than zero.");
ERR_FAIL_COND_MSG(p_time <= 0, vformat("%s: The wait time should be greater than 0 seconds, but a wait time of %f was provided.", is_inside_tree() ? String(get_path()) : String(get_name()) + " (out-of-tree)", p_time));
wait_time = p_time;
update_configuration_warnings();
}
@ -106,7 +106,7 @@ bool Timer::has_autostart() const {
}
void Timer::start(double p_time) {
ERR_FAIL_COND_MSG(!is_inside_tree(), "Timer was not added to the SceneTree. Either add it or set autostart to true.");
ERR_FAIL_COND_MSG(!is_inside_tree(), vformat("%s (out-of-tree): Timer was not added to the SceneTree. Either add it to the SceneTree using `add_child()`, or set the `autostart` property to `true`.", get_name()));
if (p_time > 0) {
set_wait_time(p_time);