godotengine
/
godot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

[Core] Fix incorrect comparison for `Array` const iterator

This commit is contained in:
A Thousand Ships 2024-04-13 17:23:25 +02:00
parent 43b32f9d0b
commit 80cb914e06
No known key found for this signature in database
GPG Key ID: 2033189A662F8BD7
2 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
core/variant/array.h
View File

@ -54,7 +54,7 @@ public:
_FORCE_INLINE_ ConstIterator &operator--();
_FORCE_INLINE_ bool operator==(const ConstIterator &p_other) const { return element_ptr == p_other.element_ptr; }
_FORCE_INLINE_ bool operator!=(const ConstIterator &p_other) const { return element_ptr == p_other.element_ptr; }
_FORCE_INLINE_ bool operator!=(const ConstIterator &p_other) const { return element_ptr != p_other.element_ptr; }
_FORCE_INLINE_ ConstIterator(const Variant *p_element_ptr, Variant *p_read_only = nullptr) :
element_ptr(p_element_ptr), read_only(p_read_only) {}

4
tests/core/variant/test_array.h
View File

@ -555,6 +555,8 @@ TEST_CASE("[Array] Iteration") {
idx++;
}
CHECK_EQ(idx, a1.size());
idx = 0;
for (const Variant &E : (const Array &)a1) {
@ -562,6 +564,8 @@ TEST_CASE("[Array] Iteration") {
idx++;
}
CHECK_EQ(idx, a1.size());
a1.clear();
}