godotengine
/
godot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge pull request #88785 from KoBeWi/list_cringe 

Fix inefficient list iteration in Node
This commit is contained in:
Rémi Verschelde 2024-02-25 11:50:16 +01:00
parent ec901ae16e 75ba837612
commit 81f3d43cc1
No known key found for this signature in database
GPG Key ID: C3336907360768E1
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
scene/main/node.cpp
View File

@ -2963,12 +2963,12 @@ void Node::replace_by(Node *p_node, bool p_keep_groups) {
} }
p_node->set_owner(owner); p_node->set_owner(owner);
for (int i = 0; i < owned.size(); i++) { for (Node *E : owned) {
owned[i]->set_owner(p_node); E->set_owner(p_node);
} }
for (int i = 0; i < owned_by_owner.size(); i++) { for (Node *E : owned_by_owner) {
owned_by_owner[i]->set_owner(owner); E->set_owner(owner);
} }
p_node->set_scene_file_path(get_scene_file_path()); p_node->set_scene_file_path(get_scene_file_path());