From 960a26f6c0d78f6e5176a0681aff7716d0819175 Mon Sep 17 00:00:00 2001
From: strank <strank@strank.info>
Date: Wed, 12 Jan 2022 21:13:08 -0500
Subject: [PATCH] GDScript: Fix parsing default parameter values from function
 calls

---
 modules/gdscript/gdscript_compiler.cpp        |  2 +-
 .../params_default_forward_reference.gd       |  9 +++++
 .../params_default_forward_reference.out      |  2 ++
 .../runtime/features/params_default_values.gd | 35 +++++++++++++++++++
 .../features/params_default_values.out        |  6 ++++
 5 files changed, 53 insertions(+), 1 deletion(-)
 create mode 100644 modules/gdscript/tests/scripts/analyzer/errors/params_default_forward_reference.gd
 create mode 100644 modules/gdscript/tests/scripts/analyzer/errors/params_default_forward_reference.out
 create mode 100644 modules/gdscript/tests/scripts/runtime/features/params_default_values.gd
 create mode 100644 modules/gdscript/tests/scripts/runtime/features/params_default_values.out

diff --git a/modules/gdscript/gdscript_compiler.cpp b/modules/gdscript/gdscript_compiler.cpp
index 117ca68c184..ca125d3a074 100644
--- a/modules/gdscript/gdscript_compiler.cpp
+++ b/modules/gdscript/gdscript_compiler.cpp
@@ -2019,7 +2019,7 @@ GDScriptFunction *GDScriptCompiler::_parse_function(Error &r_error, GDScript *p_
 			codegen.generator->start_parameters();
 			for (int i = p_func->parameters.size() - optional_parameters; i < p_func->parameters.size(); i++) {
 				const GDScriptParser::ParameterNode *parameter = p_func->parameters[i];
-				GDScriptCodeGenerator::Address src_addr = _parse_expression(codegen, r_error, parameter->default_value, true);
+				GDScriptCodeGenerator::Address src_addr = _parse_expression(codegen, r_error, parameter->default_value);
 				if (r_error) {
 					memdelete(codegen.generator);
 					return nullptr;
diff --git a/modules/gdscript/tests/scripts/analyzer/errors/params_default_forward_reference.gd b/modules/gdscript/tests/scripts/analyzer/errors/params_default_forward_reference.gd
new file mode 100644
index 00000000000..05d9bd6a3da
--- /dev/null
+++ b/modules/gdscript/tests/scripts/analyzer/errors/params_default_forward_reference.gd
@@ -0,0 +1,9 @@
+# https://github.com/godotengine/godot/issues/56702
+
+func test():
+	# somewhat obscure feature: referencing parameters in defaults, but only earlier ones!
+	ref_default("non-optional")
+
+
+func ref_default(nondefault1, defa=nondefault1, defb=defc, defc=1):
+	prints(nondefault1, nondefault2, defa, defb, defc)
diff --git a/modules/gdscript/tests/scripts/analyzer/errors/params_default_forward_reference.out b/modules/gdscript/tests/scripts/analyzer/errors/params_default_forward_reference.out
new file mode 100644
index 00000000000..1d5b5bf393b
--- /dev/null
+++ b/modules/gdscript/tests/scripts/analyzer/errors/params_default_forward_reference.out
@@ -0,0 +1,2 @@
+GDTEST_ANALYZER_ERROR
+Identifier "defc" not declared in the current scope.
diff --git a/modules/gdscript/tests/scripts/runtime/features/params_default_values.gd b/modules/gdscript/tests/scripts/runtime/features/params_default_values.gd
new file mode 100644
index 00000000000..8156b4ec684
--- /dev/null
+++ b/modules/gdscript/tests/scripts/runtime/features/params_default_values.gd
@@ -0,0 +1,35 @@
+# https://github.com/godotengine/godot/issues/56702
+
+func test():
+	const_default()
+	func_result_default()
+	# calling again will run the initializer again,
+	# as the default is not evaluated at time of defining the function (as in python)
+	# but every time the function is called (as in C++)
+	func_result_default()
+	lots_of_defaults("non-optional")
+	# somewhat obscure feature: referencing earlier parameters
+	ref_default("non-optional", 42)
+
+
+func const_default(param=42):
+	print(param)
+
+
+var default_val := 0
+
+func get_default():
+	default_val += 1
+	return default_val
+
+
+func func_result_default(param=get_default()):
+	print(param)
+
+
+func lots_of_defaults(nondefault, one=1, two=2, three=get_default()):
+	prints(nondefault, one, two, three)
+
+
+func ref_default(nondefault1, nondefault2, defa=nondefault1, defb=nondefault2 - 1):
+	prints(nondefault1, nondefault2, defa, defb)
diff --git a/modules/gdscript/tests/scripts/runtime/features/params_default_values.out b/modules/gdscript/tests/scripts/runtime/features/params_default_values.out
new file mode 100644
index 00000000000..50e0885ae50
--- /dev/null
+++ b/modules/gdscript/tests/scripts/runtime/features/params_default_values.out
@@ -0,0 +1,6 @@
+GDTEST_OK
+42
+1
+2
+non-optional 1 2 3
+non-optional 42 non-optional 41