godotengine
/
godot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

[3.x] Bounds fixes in `TextureAtlas` import 

(cherry picked from commit e34619a605)
This commit is contained in:
Ninni Pipping 2023-05-24 10:08:25 +02:00 committed by Rémi Verschelde
parent e12f95b80d
commit 86fbd1514e
No known key found for this signature in database
GPG Key ID: C3336907360768E1
2 changed files with 7 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
editor/editor_atlas_packer.cpp
View File

@ -105,7 +105,7 @@ void EditorAtlasPacker::chart_pack(Vector<Chart> &charts, int &r_width, int &r_h
Ref<BitMap> src_bitmap; Ref<BitMap> src_bitmap;
src_bitmap.instance(); src_bitmap.instance();
src_bitmap->create(aabb.size / divide_by); src_bitmap->create(Size2(Math::ceil(aabb.size.x / (real_t)divide_by), Math::ceil(aabb.size.y / (real_t)divide_by)));
int w = src_bitmap->get_size().width; int w = src_bitmap->get_size().width;
int h = src_bitmap->get_size().height; int h = src_bitmap->get_size().height;

11
editor/import/resource_importer_texture_atlas.cpp
View File

@ -96,7 +96,8 @@ Error ResourceImporterTextureAtlas::import(const String &p_source_file, const St
return OK; return OK;
} }
static void _plot_triangle(Vector2 *vertices, const Vector2 &p_offset, bool p_transposed, Ref<Image> p_image, const Ref<Image> &p_src_image) { // FIXME: Rasterization has issues, see https://github.com/godotengine/godot/issues/68350#issuecomment-1305610290
static void _plot_triangle(Vector2 *p_vertices, const Vector2 &p_offset, bool p_transposed, Ref<Image> p_image, const Ref<Image> &p_src_image) {
int width = p_image->get_width(); int width = p_image->get_width();
int height = p_image->get_height(); int height = p_image->get_height();
int src_width = p_src_image->get_width(); int src_width = p_src_image->get_width();
@ -106,8 +107,8 @@ static void _plot_triangle(Vector2 *vertices, const Vector2 &p_offset, bool p_tr
int y[3]; int y[3];
for (int j = 0; j < 3; j++) { for (int j = 0; j < 3; j++) {
x[j] = vertices[j].x; x[j] = p_vertices[j].x;
y[j] = vertices[j].y; y[j] = p_vertices[j].y;
} }
// sort the points vertically // sort the points vertically
@ -129,7 +130,7 @@ static void _plot_triangle(Vector2 *vertices, const Vector2 &p_offset, bool p_tr
double dx_low = double(x[2] - x[1]) / (y[2] - y[1] + 1); double dx_low = double(x[2] - x[1]) / (y[2] - y[1] + 1);
double xf = x[0]; double xf = x[0];
double xt = x[0] + dx_upper; // if y[0] == y[1], special case double xt = x[0] + dx_upper; // if y[0] == y[1], special case
int max_y = MIN(y[2], height - p_offset.y - 1); int max_y = MIN(y[2], p_transposed ? (width - p_offset.x - 1) : (height - p_offset.y - 1));
for (int yi = y[0]; yi < max_y; yi++) { for (int yi = y[0]; yi < max_y; yi++) {
if (yi >= 0) { if (yi >= 0) {
for (int xi = (xf > 0 ? int(xf) : 0); xi < (xt <= src_width ? xt : src_width); xi++) { for (int xi = (xf > 0 ? int(xf) : 0); xi < (xt <= src_width ? xt : src_width); xi++) {
@ -246,7 +247,7 @@ Error ResourceImporterTextureAtlas::import_group_file(const String &p_group_file
Ref<BitMap> bit_map; Ref<BitMap> bit_map;
bit_map.instance(); bit_map.instance();
bit_map->create_from_image_alpha(image); bit_map->create_from_image_alpha(image);
Vector<Vector<Vector2>> polygons = bit_map->clip_opaque_to_polygons(Rect2(0, 0, image->get_width(), image->get_height())); Vector<Vector<Vector2>> polygons = bit_map->clip_opaque_to_polygons(Rect2(Vector2(), image->get_size()));
for (int j = 0; j < polygons.size(); j++) { for (int j = 0; j < polygons.size(); j++) {
EditorAtlasPacker::Chart chart; EditorAtlasPacker::Chart chart;