godotengine
/
godot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge pull request #50561 from Calinou/fix-scene-tree-duplicate-selection-3.x 

Fix duplicate selection in SceneTree (3.x)
This commit is contained in:
Rémi Verschelde 2021-07-22 16:41:59 +02:00 committed by GitHub
parent 86054e00bf 8f448b5830
commit 883bb2f4f6
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 17 additions and 25 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

40
editor/scene_tree_editor.cpp
View File

@ -426,7 +426,6 @@ bool SceneTreeEditor::_add_nodes(Node *p_node, TreeItem *p_parent, bool p_scroll
} }
if (!valid) { if (!valid) {
//item->set_selectable(0,marked_selectable);
item->set_custom_color(0, get_color("disabled_font_color", "Editor")); item->set_custom_color(0, get_color("disabled_font_color", "Editor"));
item->set_selectable(0, false); item->set_selectable(0, false);
} }
@ -534,7 +533,7 @@ void SceneTreeEditor::_node_removed(Node *p_node) {
if (p_node == selected) { if (p_node == selected) {
selected = nullptr; selected = nullptr;
emit_signal("node_selected"); _emit_node_selected();
} }
} }
@ -619,24 +618,6 @@ void SceneTreeEditor::_tree_changed() {
pending_test_update = true; pending_test_update = true;
} }
void SceneTreeEditor::_selected_changed() {
TreeItem *s = tree->get_selected();
ERR_FAIL_COND(!s);
NodePath np = s->get_metadata(0);
Node *n = get_node(np);
if (n == selected) {
return;
}
selected = get_node(np);
blocked++;
emit_signal("node_selected");
blocked--;
}
void SceneTreeEditor::_deselect_items() { void SceneTreeEditor::_deselect_items() {
// Clear currently selected items in scene tree dock. // Clear currently selected items in scene tree dock.
if (editor_selection) { if (editor_selection) {
@ -645,6 +626,12 @@ void SceneTreeEditor::_deselect_items() {
} }
} }
void SceneTreeEditor::_emit_node_selected() {
blocked++;
emit_signal("node_selected");
blocked--;
}
void SceneTreeEditor::_cell_multi_selected(Object *p_object, int p_cell, bool p_selected) { void SceneTreeEditor::_cell_multi_selected(Object *p_object, int p_cell, bool p_selected) {
TreeItem *item = Object::cast_to<TreeItem>(p_object); TreeItem *item = Object::cast_to<TreeItem>(p_object);
ERR_FAIL_COND(!item); ERR_FAIL_COND(!item);
@ -667,7 +654,13 @@ void SceneTreeEditor::_cell_multi_selected(Object *p_object, int p_cell, bool p_
} else { } else {
editor_selection->remove_node(n); editor_selection->remove_node(n);
} }
emit_signal("node_changed");
if (editor_selection->get_selected_nodes().size() == 1) {
selected = editor_selection->get_selected_node_list()[0];
_emit_node_selected();
} else {
emit_signal("node_changed");
}
} }
void SceneTreeEditor::_notification(int p_what) { void SceneTreeEditor::_notification(int p_what) {
@ -754,7 +747,7 @@ void SceneTreeEditor::set_selected(Node *p_node, bool p_emit_selected) {
} }
if (p_emit_selected) { if (p_emit_selected) {
emit_signal("node_selected"); _emit_node_selected();
} }
} }
@ -1142,7 +1135,6 @@ void SceneTreeEditor::_bind_methods() {
ClassDB::bind_method(D_METHOD("_update_tree", "scroll_to_selected"), &SceneTreeEditor::_update_tree, DEFVAL(false)); ClassDB::bind_method(D_METHOD("_update_tree", "scroll_to_selected"), &SceneTreeEditor::_update_tree, DEFVAL(false));
ClassDB::bind_method("_node_removed", &SceneTreeEditor::_node_removed); ClassDB::bind_method("_node_removed", &SceneTreeEditor::_node_removed);
ClassDB::bind_method("_node_renamed", &SceneTreeEditor::_node_renamed); ClassDB::bind_method("_node_renamed", &SceneTreeEditor::_node_renamed);
ClassDB::bind_method("_selected_changed", &SceneTreeEditor::_selected_changed);
ClassDB::bind_method("_deselect_items", &SceneTreeEditor::_deselect_items); ClassDB::bind_method("_deselect_items", &SceneTreeEditor::_deselect_items);
ClassDB::bind_method("_renamed", &SceneTreeEditor::_renamed); ClassDB::bind_method("_renamed", &SceneTreeEditor::_renamed);
ClassDB::bind_method("_rename_node", &SceneTreeEditor::_rename_node); ClassDB::bind_method("_rename_node", &SceneTreeEditor::_rename_node);
@ -1216,12 +1208,10 @@ SceneTreeEditor::SceneTreeEditor(bool p_label, bool p_can_rename, bool p_can_ope
tree->connect("empty_tree_rmb_selected", this, "_rmb_select"); tree->connect("empty_tree_rmb_selected", this, "_rmb_select");
} }
tree->connect("cell_selected", this, "_selected_changed");
tree->connect("item_edited", this, "_renamed", varray(), CONNECT_DEFERRED); tree->connect("item_edited", this, "_renamed", varray(), CONNECT_DEFERRED);
tree->connect("multi_selected", this, "_cell_multi_selected"); tree->connect("multi_selected", this, "_cell_multi_selected");
tree->connect("button_pressed", this, "_cell_button_pressed"); tree->connect("button_pressed", this, "_cell_button_pressed");
tree->connect("nothing_selected", this, "_deselect_items"); tree->connect("nothing_selected", this, "_deselect_items");
//tree->connect("item_edited", this,"_renamed",Vector<Variant>(),true);
error = memnew(AcceptDialog); error = memnew(AcceptDialog);
add_child(error); add_child(error);

2
editor/scene_tree_editor.h
View File

@ -132,6 +132,8 @@ class SceneTreeEditor : public Control {
Vector<StringName> valid_types; Vector<StringName> valid_types;
void _emit_node_selected();
public: public:
void set_filter(const String &p_filter); void set_filter(const String &p_filter);
String get_filter() const; String get_filter() const;