From 89f4e716794e9a1cf105af6e4f5a0f7ec373afc4 Mon Sep 17 00:00:00 2001 From: Dmitriy Romanov Date: Wed, 28 Mar 2018 18:54:33 +0300 Subject: [PATCH] Fix Collada material roughness import function Fixes NaN roughness in Godot when hardness in Blender is set to more than 255. Also corrects dependency: more hardness = more roughness (it says shininess, but it actually is hardness). --- editor/import/editor_import_collada.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/editor/import/editor_import_collada.cpp b/editor/import/editor_import_collada.cpp index 863b13cbd7c..89db0191ee2 100644 --- a/editor/import/editor_import_collada.cpp +++ b/editor/import/editor_import_collada.cpp @@ -480,7 +480,7 @@ Error ColladaImport::_create_material(const String &p_target) { } } - float roughness = Math::sqrt(1.0 - ((Math::log(effect.shininess) / Math::log(2.0)) / 8.0)); //not very right.. + float roughness = - Math::sqrt(1.0 - ((Math::log(effect.shininess) / Math::log(2.0)) / 9.0)) + 1; material->set_roughness(roughness); if (effect.double_sided) {