From 7532b2d259f8644ad77c706ecdbc30b6b742b95e Mon Sep 17 00:00:00 2001
From: Rindbee <idleman@yeah.net>
Date: Thu, 18 May 2023 22:49:10 +0800
Subject: [PATCH] Don't change `RID` when changing `viewport_path` in
 `ViewportTexture`

When changing `viewport_path`, the `proxy`'s target is changed to a new placeholder.

Add a flag `vp_changed` to prevent calling `setup_local_to_scene` (mainly called by toggling `resource_local_to_scene`) when the target viewport has not changed.
---
 scene/main/viewport.cpp | 18 +++++++++++-------
 scene/main/viewport.h   |  1 +
 2 files changed, 12 insertions(+), 7 deletions(-)

diff --git a/scene/main/viewport.cpp b/scene/main/viewport.cpp
index e7970b212ee..c2d1f9e0d38 100644
--- a/scene/main/viewport.cpp
+++ b/scene/main/viewport.cpp
@@ -61,6 +61,11 @@
 #include "servers/rendering/rendering_server_globals.h"
 
 void ViewportTexture::setup_local_to_scene() {
+	// For the same target viewport, setup is only allowed once to prevent multiple free or multiple creations.
+	if (!vp_changed) {
+		return;
+	}
+
 	if (vp_pending) {
 		return;
 	}
@@ -89,20 +94,17 @@ void ViewportTexture::set_viewport_path_in_scene(const NodePath &p_path) {
 	}
 
 	path = p_path;
+	vp_changed = true;
 
 	if (vp) {
 		vp->viewport_textures.erase(this);
 		vp = nullptr;
 	}
 
-	if (proxy_ph.is_valid()) {
-		RS::get_singleton()->free(proxy_ph);
+	if (proxy.is_valid() && proxy_ph.is_null()) {
+		proxy_ph = RS::get_singleton()->texture_2d_placeholder_create();
+		RS::get_singleton()->texture_proxy_update(proxy, proxy_ph);
 	}
-	if (proxy.is_valid()) {
-		RS::get_singleton()->free(proxy);
-	}
-	proxy_ph = RID();
-	proxy = RID();
 
 	if (get_local_scene() && !path.is_empty()) {
 		setup_local_to_scene();
@@ -181,11 +183,13 @@ void ViewportTexture::_setup_local_to_scene(const Node *p_loc_scene) {
 	if (proxy_ph.is_valid()) {
 		RS::get_singleton()->texture_proxy_update(proxy, vp->texture_rid);
 		RS::get_singleton()->free(proxy_ph);
+		proxy_ph = RID();
 	} else {
 		ERR_FAIL_COND(proxy.is_valid()); // Should be invalid.
 		proxy = RS::get_singleton()->texture_proxy_create(vp->texture_rid);
 	}
 	vp_pending = false;
+	vp_changed = false;
 
 	emit_changed();
 }
diff --git a/scene/main/viewport.h b/scene/main/viewport.h
index 63cddddbcbb..07c31ebf004 100644
--- a/scene/main/viewport.h
+++ b/scene/main/viewport.h
@@ -60,6 +60,7 @@ class ViewportTexture : public Texture2D {
 	friend class Viewport;
 	Viewport *vp = nullptr;
 	bool vp_pending = false;
+	bool vp_changed = false;
 
 	void _setup_local_to_scene(const Node *p_loc_scene);