From 8d22a5f4c01f99751353fcd516aa409d036e972a Mon Sep 17 00:00:00 2001 From: Fredia Huya-Kouadio Date: Wed, 31 Aug 2022 12:36:54 -0700 Subject: [PATCH] Fix build failures for Android on Windows The issue is caused by https://github.com/godotengine/godot/pull/64306 which makes use of a 3.7 feature while the current recommended python version is 3.5 for 3.x and 3.6 for master. (cherry picked from commit 667f4ed742e0010adb678dff45e004310c4886d4) --- methods.py | 21 +++++++++++---------- 1 file changed, 11 insertions(+), 10 deletions(-) diff --git a/methods.py b/methods.py index 91135a1b910..7d14f619a32 100644 --- a/methods.py +++ b/methods.py @@ -325,16 +325,17 @@ def use_windows_spawn_fix(self, platform=None): startupinfo = subprocess.STARTUPINFO() startupinfo.dwFlags |= subprocess.STARTF_USESHOWWINDOW - proc = subprocess.Popen( - cmdline, - stdin=subprocess.PIPE, - stdout=subprocess.PIPE, - stderr=subprocess.PIPE, - startupinfo=startupinfo, - shell=False, - env=env, - text=True, - ) + popen_args = { + "stdin": subprocess.PIPE, + "stdout": subprocess.PIPE, + "stderr": subprocess.PIPE, + "startupinfo": startupinfo, + "shell": False, + "env": env, + } + if sys.version_info >= (3, 7, 0): + popen_args["text"] = True + proc = subprocess.Popen(cmdline, **popen_args) _, err = proc.communicate() rv = proc.wait() if rv: