godotengine
/
godot
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Disable threading in Asset Library 

Threaded HTTPRequest appears to be crashy on 3.0.x.
Fixes #19336.
This commit is contained in:
Rémi Verschelde 2018-06-22 09:30:17 +02:00
parent 4d7aa0b762
commit 909eaede4c
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
editor/plugins/asset_library_editor_plugin.cpp
View File

@ -515,7 +515,8 @@ EditorAssetLibraryItemDownload::EditorAssetLibraryItemDownload() {
download = memnew(HTTPRequest); download = memnew(HTTPRequest);
add_child(download); add_child(download);
download->connect("request_completed", this, "_http_download_completed"); download->connect("request_completed", this, "_http_download_completed");
download->set_use_threads(EDITOR_DEF("asset_library/use_threads", true)); // Threaded HTTPRequest causes crashes (GH-19336)
download->set_use_threads(false);
download_error = memnew(AcceptDialog); download_error = memnew(AcceptDialog);
add_child(download_error); add_child(download_error);
@ -834,7 +835,8 @@ void EditorAssetLibrary::_request_image(ObjectID p_for, String p_image_url, Imag
iq.image_index = p_image_index; iq.image_index = p_image_index;
iq.image_type = p_type; iq.image_type = p_type;
iq.request = memnew(HTTPRequest); iq.request = memnew(HTTPRequest);
iq.request->set_use_threads(EDITOR_DEF("asset_library/use_threads", true)); // Threaded HTTPRequest causes crashes (GH-19336)
iq.request->set_use_threads(false);
iq.target = p_for; iq.target = p_for;
iq.queue_id = ++last_queue_id; iq.queue_id = ++last_queue_id;