From 91215e191992f3cbbbf4fe047b000ac5a403085c Mon Sep 17 00:00:00 2001 From: Nicolas Silva Date: Mon, 5 Feb 2018 16:01:24 +0100 Subject: [PATCH] Fix polygon triangulation failure. The ear clipping algorithm used to triangulate polygons has a slightly too conservative point-in-triangle test which can, in some configurations prevent it from finding a possible tessellation. Relaxing the test by considering that points exactly on edges don't belong the triangle fixes the issue. Changing the semantic of the test is safe because no other code makes use of it. A more detailed explanation can be found in issue #16395. Fixes #16395. --- core/math/triangulate.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/core/math/triangulate.cpp b/core/math/triangulate.cpp index 957e16f92ca..5bae74ac7e5 100644 --- a/core/math/triangulate.cpp +++ b/core/math/triangulate.cpp @@ -74,7 +74,7 @@ bool Triangulate::is_inside_triangle(real_t Ax, real_t Ay, cCROSSap = cx * apy - cy * apx; bCROSScp = bx * cpy - by * cpx; - return ((aCROSSbp >= 0.0) && (bCROSScp >= 0.0) && (cCROSSap >= 0.0)); + return ((aCROSSbp > 0.0) && (bCROSScp > 0.0) && (cCROSSap > 0.0)); }; bool Triangulate::snip(const Vector &p_contour, int u, int v, int w, int n, const Vector &V) {